src/crankshaft/ia32/lithium-codegen-ia32.cc - Issue 2028633002: Provide a tagged allocation top pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/ia32/lithium-codegen-ia32.cc

Issue 2028633002: Provide a tagged allocation top pointer. Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: WIP: adding a few tests. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/ia32/lithium-codegen-ia32.cc

diff --git a/src/crankshaft/ia32/lithium-codegen-ia32.cc b/src/crankshaft/ia32/lithium-codegen-ia32.cc

index cdd96a0826f6f28ea989c42278113b1614c92372..c9d64b0d237cbcdbeb496c5c9a9a61fdf237c6ff 100644

--- a/src/crankshaft/ia32/lithium-codegen-ia32.cc

+++ b/src/crankshaft/ia32/lithium-codegen-ia32.cc

@@ -4943,9 +4943,7 @@ void LCodeGen::DoDeferredAllocate(LAllocate* instr) {

// undo the allocation.

ExternalReference allocation_top =

AllocationUtils::GetAllocationTopReference(isolate(), allocation_flags);

- __ sub(eax, Immediate(kHeapObjectTag));

__ mov(Operand::StaticVariable(allocation_top), eax);

- __ add(eax, Immediate(kHeapObjectTag));

}