src/crankshaft/arm64/lithium-codegen-arm64.cc - Issue 2028633002: Provide a tagged allocation top pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/arm64/lithium-codegen-arm64.cc

Issue 2028633002: Provide a tagged allocation top pointer. Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: WIP: adding a few tests. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/arm64/lithium-codegen-arm64.cc

diff --git a/src/crankshaft/arm64/lithium-codegen-arm64.cc b/src/crankshaft/arm64/lithium-codegen-arm64.cc

index 422b7271b4e9b7ecd76dc74cac8e1017361006c6..45db1879233bb5a059a106fa022a50a8436be170 100644

--- a/src/crankshaft/arm64/lithium-codegen-arm64.cc

+++ b/src/crankshaft/arm64/lithium-codegen-arm64.cc

@@ -1493,10 +1493,8 @@ void LCodeGen::DoDeferredAllocate(LAllocate* instr) {

ExternalReference allocation_top =

AllocationUtils::GetAllocationTopReference(isolate(), allocation_flags);

- __ Sub(x0, x0, Operand(kHeapObjectTag));

__ Mov(top_address, Operand(allocation_top));

__ Str(x0, MemOperand(top_address));

- __ Add(x0, x0, Operand(kHeapObjectTag));

}