Provide a tagged allocation top pointer.

Provide a tagged allocation top pointer.

Taking over http://crrev.com/1924223002.

BUG=chromium:606711
LOG=N

Committed: https://crrev.com/f42c9e93c80fdf57e8f92bb87f6ed927d0ae4028
Committed: https://crrev.com/c99caf307ba3bb1b1cf08bf4172f503754c41341
Cr-Original-Commit-Position: refs/heads/master@{#36633}
Cr-Commit-Position: refs/heads/master@{#36742}

[epertoso, 2016-05-31 14:08:15]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-31 14:08:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028633002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028633002/1

[epertoso, 2016-05-31 14:15:53]

Description was changed from

==========
Provide a tagged allocation top pointer.
==========

to

==========
Provide a tagged allocation top pointer.

Taking over http://crrev.com/1924223002.

BUG=chromium:606711
LOG=N
==========

[epertoso, 2016-05-31 14:15:53]

epertoso@chromium.org changed reviewers:
+ bmeurer@chromium.org, hpayer@chromium.org

[commit-bot: I haz the power, 2016-05-31 14:25:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 14:25:38]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/1...)

[epertoso, 2016-05-31 15:06:25]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-31 15:06:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028633002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028633002/20001

[commit-bot: I haz the power, 2016-05-31 15:11:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 15:12:00]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/6538)

[epertoso, 2016-05-31 15:30:31]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-31 15:30:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028633002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028633002/40001

[commit-bot: I haz the power, 2016-05-31 15:58:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 15:58:25]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2016-05-31 18:19:35]

lgtm

https://codereview.chromium.org/2028633002/diff/40001/src/heap/spaces.h
File src/heap/spaces.h (right):

https://codereview.chromium.org/2028633002/diff/40001/src/heap/spaces.h#newco...
src/heap/spaces.h:1664: // Current allocation limit.
Mention that limit is untagged.

[Benedikt Meurer, 2016-05-31 18:47:21]

LGTM.

[epertoso, 2016-06-01 08:06:23]

https://codereview.chromium.org/2028633002/diff/40001/src/heap/spaces.h
File src/heap/spaces.h (right):

https://codereview.chromium.org/2028633002/diff/40001/src/heap/spaces.h#newco...
src/heap/spaces.h:1664: // Current allocation limit.
On 2016/05/31 at 18:19:35, Hannes Payer wrote:
> Mention that limit is untagged.

Done.

[epertoso, 2016-06-01 08:06:27]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2016-06-01 08:06:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2028633002/#ps60001
(title: "Update")

[commit-bot: I haz the power, 2016-06-01 08:06:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028633002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028633002/60001

[commit-bot: I haz the power, 2016-06-01 08:37:28]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-01 08:39:15]

Description was changed from

==========
Provide a tagged allocation top pointer.

Taking over http://crrev.com/1924223002.

BUG=chromium:606711
LOG=N
==========

to

==========
Provide a tagged allocation top pointer.

Taking over http://crrev.com/1924223002.

BUG=chromium:606711
LOG=N

Committed: https://crrev.com/f42c9e93c80fdf57e8f92bb87f6ed927d0ae4028
Cr-Commit-Position: refs/heads/master@{#36633}
==========

[commit-bot: I haz the power, 2016-06-01 08:39:16]

Patchset 4 (id:??) landed as
https://crrev.com/f42c9e93c80fdf57e8f92bb87f6ed927d0ae4028
Cr-Commit-Position: refs/heads/master@{#36633}

[Michael Achenbach, 2016-06-01 10:32:10]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2016-06-01 10:32:11]

FYI: This leads to flaky crashes in a wasm test:
https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/10598
https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds...

[epertoso, 2016-06-01 11:00:52]

On 2016/06/01 at 10:32:11, machenbach wrote:
> FYI: This leads to flaky crashes in a wasm test:
> https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/10598
>
https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds...

I've been trying to reproduce the failure locally with no luck. I'm reverting
this CL, so we can see what happens.

[epertoso, 2016-06-01 11:01:56]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2031493002/ by epertoso@chromium.org.

The reason for reverting is: Seems to be causing flakiness in some wasm tests: 

https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/10598
https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds...
.

[epertoso, 2016-06-06 10:49:08]

On 2016/06/01 at 11:01:56, epertoso wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2031493002/ by epertoso@chromium.org.
> 
> The reason for reverting is: Seems to be causing flakiness in some wasm tests:

> 
> https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/10598
>
https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds...
> .

machenbach@: seems like this CL triggered http://crbug.com/v8/5067. I've patched
LCodeGen in http://crrev.com/2033413002, is it OK to re-land this one?

[Michael Achenbach, 2016-06-06 11:02:28]

On 2016/06/06 10:49:08, epertoso wrote:
> On 2016/06/01 at 11:01:56, epertoso wrote:
> > A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/2031493002/ by mailto:epertoso@chromium.org.
> > 
> > The reason for reverting is: Seems to be causing flakiness in some wasm
tests:
> 
> > 
> > https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/10598
> >
>
https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds...
> > .
> 
> machenbach@: seems like this CL triggered http://crbug.com/v8/5067. I've
patched
> LCodeGen in http://crrev.com/2033413002, is it OK to re-land this one?

go ahead, thanks

[epertoso, 2016-06-06 12:01:50]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2016-06-06 12:01:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2028633002/#ps80001
(title: "Update")

[commit-bot: I haz the power, 2016-06-06 12:01:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028633002/80001

[commit-bot: I haz the power, 2016-06-06 12:30:28]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-06 12:32:05]

Description was changed from

==========
Provide a tagged allocation top pointer.

Taking over http://crrev.com/1924223002.

BUG=chromium:606711
LOG=N

Committed: https://crrev.com/f42c9e93c80fdf57e8f92bb87f6ed927d0ae4028
Cr-Commit-Position: refs/heads/master@{#36633}
==========

to

==========
Provide a tagged allocation top pointer.

Taking over http://crrev.com/1924223002.

BUG=chromium:606711
LOG=N

Committed: https://crrev.com/f42c9e93c80fdf57e8f92bb87f6ed927d0ae4028
Committed: https://crrev.com/c99caf307ba3bb1b1cf08bf4172f503754c41341
Cr-Original-Commit-Position: refs/heads/master@{#36633}
Cr-Commit-Position: refs/heads/master@{#36742}
==========

[commit-bot: I haz the power, 2016-06-06 12:32:06]

Patchset 5 (id:??) landed as
https://crrev.com/c99caf307ba3bb1b1cf08bf4172f503754c41341
Cr-Commit-Position: refs/heads/master@{#36742}

[epertoso, 2016-06-06 15:11:41]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2035413003/ by epertoso@chromium.org.

The reason for reverting is: d8 segfaults on some benchmarks on ia32.
Investigating..

[titzer, 2017-02-20 11:32:34]

Description was changed from

==========
Provide a tagged allocation top pointer.

Taking over http://crrev.com/1924223002.

BUG=chromium:606711
LOG=N

Committed: https://crrev.com/f42c9e93c80fdf57e8f92bb87f6ed927d0ae4028
Committed: https://crrev.com/c99caf307ba3bb1b1cf08bf4172f503754c41341
Cr-Original-Commit-Position: refs/heads/master@{#36633}
Cr-Commit-Position: refs/heads/master@{#36742}
==========

to

==========
Provide a tagged allocation top pointer.

Taking over http://crrev.com/1924223002.

BUG=chromium:606711
LOG=N

Committed: https://crrev.com/f42c9e93c80fdf57e8f92bb87f6ed927d0ae4028
Committed: https://crrev.com/c99caf307ba3bb1b1cf08bf4172f503754c41341
Cr-Original-Commit-Position: refs/heads/master@{#36633}
Cr-Commit-Position: refs/heads/master@{#36742}
==========