Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2028623002:
[build] Use sysroot for linux compilation with clang (Closed)
|
Created:
4 years, 6 months ago by Michael Achenbach Modified:
4 years, 6 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[build] Use sysroot for linux compilation with clang
This ports the configuration for using a sysroot from
chromium's common.gypi.
This is restricted to clang only.
BUG=chromium:474921, chromium:616032
LOG=y
Committed: https://crrev.com/c47d3c63695d2999752f5fc61ff171f3ff100553
Committed: https://crrev.com/c4fab3ec25663fd6676f1bddc12a2b5cacec0d54
Cr-Original-Commit-Position: refs/heads/master@{#36729}
Cr-Commit-Position: refs/heads/master@{#36830}
Patch Set 1 #Patch Set 2 : Restrict to clang #
Total comments: 2
Patch Set 3 : Only support x64 and ia32 #Patch Set 4 : Default + rebase #Patch Set 5 : Rebase #Patch Set 6 : Merged fix from https://codereview.chromium.org/2040803005/ #Messages
Total messages: 57 (28 generated)
Description was changed from ========== [build] Use sysroot for linux compilation BUG= ========== to ========== [build] Use sysroot for linux compilation BUG=chromium:474921, chromium:616032 ==========
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028623002/1
Description was changed from ========== [build] Use sysroot for linux compilation BUG=chromium:474921, chromium:616032 ========== to ========== [build] Use sysroot for linux compilation This ports the configuration for using a sysroot from chromium's common.gypi. BUG=chromium:474921, chromium:616032 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028623002/20001
Description was changed from ========== [build] Use sysroot for linux compilation This ports the configuration for using a sysroot from chromium's common.gypi. BUG=chromium:474921, chromium:616032 ========== to ========== [build] Use sysroot for linux compilation with clang This ports the configuration for using a sysroot from chromium's common.gypi. This is restricted to clang only. BUG=chromium:474921, chromium:616032 ==========
machenbach@chromium.org changed reviewers: + jochen@chromium.org, vogelheim@chromium.org
PTAL. I couldn't get the gcc case to run. Clang seems to be smart and only needs the --sysroot flag. Gcc wants all include and library flags, which chromium seems to get from calling a pkg-config wrapper on a bunch of targets. I couldn't get that to work yet. With gcc we only have bots that test where they build. So this shouldn't be a blocker.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2028623002/diff/20001/gypfiles/standalone.gypi File gypfiles/standalone.gypi (right): https://codereview.chromium.org/2028623002/diff/20001/gypfiles/standalone.gyp... gypfiles/standalone.gypi:99: ], I'm not sure what gyp does if OS is linux, use_sysroot is 1, but the target_arch is different from those 4. (Not sure this is worth fixing. The gyp conditional syntax is kind of horrible, really.)
https://codereview.chromium.org/2028623002/diff/20001/gypfiles/standalone.gypi File gypfiles/standalone.gypi (right): https://codereview.chromium.org/2028623002/diff/20001/gypfiles/standalone.gyp... gypfiles/standalone.gypi:99: ], On 2016/06/01 10:51:19, vogelheim wrote: > I'm not sure what gyp does if OS is linux, use_sysroot is 1, but the target_arch > is different from those 4. > > (Not sure this is worth fixing. The gyp conditional syntax is kind of horrible, > really.) I think it'll error out. So one should not set use_sysroot=1 in that case. An if-else-if structure for the conditions above gets horribly nested in gyp. Or we could provide a default on some structure level, but I think it's not worth it as we can just set use_sysroot=0
On 2016/06/01 11:20:37, Michael Achenbach wrote: > https://codereview.chromium.org/2028623002/diff/20001/gypfiles/standalone.gypi > File gypfiles/standalone.gypi (right): > > https://codereview.chromium.org/2028623002/diff/20001/gypfiles/standalone.gyp... > gypfiles/standalone.gypi:99: ], > On 2016/06/01 10:51:19, vogelheim wrote: > > I'm not sure what gyp does if OS is linux, use_sysroot is 1, but the > target_arch > > is different from those 4. > > > > (Not sure this is worth fixing. The gyp conditional syntax is kind of > horrible, > > really.) > > I think it'll error out. So one should not set use_sysroot=1 in that case. An > if-else-if structure for the conditions above gets horribly nested in gyp. Or we > could provide a default on some structure level, but I think it's not worth it > as we can just set use_sysroot=0 Agreed.
On 2016/06/01 11:20:37, Michael Achenbach wrote: > https://codereview.chromium.org/2028623002/diff/20001/gypfiles/standalone.gypi > File gypfiles/standalone.gypi (right): > > https://codereview.chromium.org/2028623002/diff/20001/gypfiles/standalone.gyp... > gypfiles/standalone.gypi:99: ], > On 2016/06/01 10:51:19, vogelheim wrote: > > I'm not sure what gyp does if OS is linux, use_sysroot is 1, but the > target_arch > > is different from those 4. > > > > (Not sure this is worth fixing. The gyp conditional syntax is kind of > horrible, > > really.) > > I think it'll error out. So one should not set use_sysroot=1 in that case. An > if-else-if structure for the conditions above gets horribly nested in gyp. Or we > could provide a default on some structure level, but I think it's not worth it > as we can just set use_sysroot=0 Thinking twice, I should add a default. As I'd otherwise need to set a use_sysroot explicitly in the infrastructure, where this won't work. E.g. on our mips big endian builder.
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028623002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/8107) v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/1...) v8_win_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/8004)
Patch is again like 2 with a default. After https://codereview.chromium.org/2027873004/ landed, the script doesn't error out for unknown archs.
On 2016/06/02 08:31:13, Michael Achenbach wrote: > Patch is again like 2 with a default. After > https://codereview.chromium.org/2027873004/ landed, the script doesn't error out > for unknown archs. Meant patch 4. PTAL.
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028623002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028623002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/8054) v8_win_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028623002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028623002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [build] Use sysroot for linux compilation with clang This ports the configuration for using a sysroot from chromium's common.gypi. This is restricted to clang only. BUG=chromium:474921, chromium:616032 ========== to ========== [build] Use sysroot for linux compilation with clang This ports the configuration for using a sysroot from chromium's common.gypi. This is restricted to clang only. BUG=chromium:474921, chromium:616032 LOG=y ==========
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028623002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028623002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/6704) v8_mac_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/2619)
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028623002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028623002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by machenbach@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vogelheim@chromium.org Link to the patchset: https://codereview.chromium.org/2028623002/#ps80001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028623002/80001
Message was sent while issue was closed.
Description was changed from ========== [build] Use sysroot for linux compilation with clang This ports the configuration for using a sysroot from chromium's common.gypi. This is restricted to clang only. BUG=chromium:474921, chromium:616032 LOG=y ========== to ========== [build] Use sysroot for linux compilation with clang This ports the configuration for using a sysroot from chromium's common.gypi. This is restricted to clang only. BUG=chromium:474921, chromium:616032 LOG=y ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== [build] Use sysroot for linux compilation with clang This ports the configuration for using a sysroot from chromium's common.gypi. This is restricted to clang only. BUG=chromium:474921, chromium:616032 LOG=y ========== to ========== [build] Use sysroot for linux compilation with clang This ports the configuration for using a sysroot from chromium's common.gypi. This is restricted to clang only. BUG=chromium:474921, chromium:616032 LOG=y Committed: https://crrev.com/c47d3c63695d2999752f5fc61ff171f3ff100553 Cr-Commit-Position: refs/heads/master@{#36729} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/c47d3c63695d2999752f5fc61ff171f3ff100553 Cr-Commit-Position: refs/heads/master@{#36729}
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2042693003/ by machenbach@chromium.org. The reason for reverting is: sysroot logic breaks "make arm".
Message was sent while issue was closed.
Description was changed from ========== [build] Use sysroot for linux compilation with clang This ports the configuration for using a sysroot from chromium's common.gypi. This is restricted to clang only. BUG=chromium:474921, chromium:616032 LOG=y Committed: https://crrev.com/c47d3c63695d2999752f5fc61ff171f3ff100553 Cr-Commit-Position: refs/heads/master@{#36729} ========== to ========== [build] Use sysroot for linux compilation with clang This ports the configuration for using a sysroot from chromium's common.gypi. This is restricted to clang only. BUG=chromium:474921, chromium:616032 LOG=y Committed: https://crrev.com/c47d3c63695d2999752f5fc61ff171f3ff100553 Cr-Commit-Position: refs/heads/master@{#36729} ==========
Fix for last revert landed here: https://codereview.chromium.org/2045173003/ Tried locally and it works now. Relanding...
The CQ bit was checked by machenbach@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vogelheim@chromium.org Link to the patchset: https://codereview.chromium.org/2028623002/#ps100001 (title: "Merged fix from https://codereview.chromium.org/2040803005/")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028623002/100001
Message was sent while issue was closed.
Description was changed from ========== [build] Use sysroot for linux compilation with clang This ports the configuration for using a sysroot from chromium's common.gypi. This is restricted to clang only. BUG=chromium:474921, chromium:616032 LOG=y Committed: https://crrev.com/c47d3c63695d2999752f5fc61ff171f3ff100553 Cr-Commit-Position: refs/heads/master@{#36729} ========== to ========== [build] Use sysroot for linux compilation with clang This ports the configuration for using a sysroot from chromium's common.gypi. This is restricted to clang only. BUG=chromium:474921, chromium:616032 LOG=y Committed: https://crrev.com/c47d3c63695d2999752f5fc61ff171f3ff100553 Cr-Commit-Position: refs/heads/master@{#36729} ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== [build] Use sysroot for linux compilation with clang This ports the configuration for using a sysroot from chromium's common.gypi. This is restricted to clang only. BUG=chromium:474921, chromium:616032 LOG=y Committed: https://crrev.com/c47d3c63695d2999752f5fc61ff171f3ff100553 Cr-Commit-Position: refs/heads/master@{#36729} ========== to ========== [build] Use sysroot for linux compilation with clang This ports the configuration for using a sysroot from chromium's common.gypi. This is restricted to clang only. BUG=chromium:474921, chromium:616032 LOG=y Committed: https://crrev.com/c47d3c63695d2999752f5fc61ff171f3ff100553 Committed: https://crrev.com/c4fab3ec25663fd6676f1bddc12a2b5cacec0d54 Cr-Original-Commit-Position: refs/heads/master@{#36729} Cr-Commit-Position: refs/heads/master@{#36830} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/c4fab3ec25663fd6676f1bddc12a2b5cacec0d54 Cr-Commit-Position: refs/heads/master@{#36830} |
