Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Issue 2027873004: sysroot installer: Don't error out for unknown target archs (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
chromium-reviews, vogelheim
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sysroot installer: Don't error out for unknown target archs V8 has several target_archs that don't have a supported sysroot image, e.g. mips (big endian), ppc, s390. This prevents the script from failing when run as a hook and when one of these architectures is used. BUG=chromium:616032 Committed: https://crrev.com/d226bb761b68fdfcc5775be574643404e0aaf09b Cr-Commit-Position: refs/heads/master@{#397129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M build/linux/sysroot_scripts/install-sysroot.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Michael Achenbach
PTAL
4 years, 6 months ago (2016-06-01 12:12:05 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027873004/1
4 years, 6 months ago (2016-06-01 12:12:11 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-01 13:02:55 UTC) #7
Paweł Hajdan Jr.
LGTM
4 years, 6 months ago (2016-06-01 13:32:43 UTC) #8
agrieve
On 2016/06/01 13:32:43, Paweł Hajdan Jr. wrote: > LGTM lgtm
4 years, 6 months ago (2016-06-01 13:42:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027873004/1
4 years, 6 months ago (2016-06-01 13:46:37 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 13:51:02 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 13:52:58 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d226bb761b68fdfcc5775be574643404e0aaf09b
Cr-Commit-Position: refs/heads/master@{#397129}

Powered by Google App Engine
This is Rietveld 408576698