[build] Ensure target_arch is set correctly in toplevel Makefile

[build] Ensure target_arch is set correctly in toplevel Makefile

This sets the target_arch for simulator builds.

Fix needed for https://codereview.chromium.org/2028623002/

BUG=chromium:616032
NOTRY=true

Committed: https://crrev.com/0d4983fbb88b1a1453791778ce29967734bbb366
Cr-Commit-Position: refs/heads/master@{#36826}

[Michael Achenbach, 2016-06-08 13:15:24]

Description was changed from

==========
[build] Ensure target_arch is set correctly in toplevel Makefile

BUG=
==========

to

==========
[build] Ensure target_arch is set correctly in toplevel Makefile

BUG=chromium:616032
==========

[Michael Achenbach, 2016-06-08 13:15:24]

machenbach@chromium.org changed reviewers:
+ jkummerow@chromium.org, vogelheim@chromium.org

[Michael Achenbach, 2016-06-08 13:21:56]

Description was changed from

==========
[build] Ensure target_arch is set correctly in toplevel Makefile

BUG=chromium:616032
==========

to

==========
[build] Ensure target_arch is set correctly in toplevel Makefile

This sets the target_arch for simulator builds.

Fix needed for https://codereview.chromium.org/2028623002/

BUG=chromium:616032
==========

[Michael Achenbach, 2016-06-08 13:22:08]

Description was changed from

==========
[build] Ensure target_arch is set correctly in toplevel Makefile

This sets the target_arch for simulator builds.

Fix needed for https://codereview.chromium.org/2028623002/

BUG=chromium:616032
==========

to

==========
[build] Ensure target_arch is set correctly in toplevel Makefile

This sets the target_arch for simulator builds.

Fix needed for https://codereview.chromium.org/2028623002/

BUG=chromium:616032
NOTRY=true
==========

[Michael Achenbach, 2016-06-08 13:22:18]

PTAL

https://codereview.chromium.org/2045173003/diff/20001/Makefile
File Makefile (right):

https://codereview.chromium.org/2045173003/diff/20001/Makefile#newcode255
Makefile:255: ARCHES32 = ia32 x32 arm mips mipsel x87 ppc s390
Not sure if simulation of x32 would require target_arch=ia32? It's this 32 bit
user space in a 64 bit system, how would a simulator run. Do we even have one? I
think we recently dropped support for x32.

https://codereview.chromium.org/2045173003/diff/20001/Makefile#newcode460
Makefile:460: -Dtarget_arch=ia32,)) \
Using ia32 is a simplification. Theoretically we'd need the 32 bit version of
CXX_TARGET_ARCH. But whoever needs this is welcome to deliver a better patch...

[jochen (gone - plz use gerrit), 2016-06-08 13:24:26]

jochen@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-06-08 13:24:29]

https://codereview.chromium.org/2045173003/diff/20001/Makefile
File Makefile (right):

https://codereview.chromium.org/2045173003/diff/20001/Makefile#newcode255
Makefile:255: ARCHES32 = ia32 x32 arm mips mipsel x87 ppc s390
On 2016/06/08 at 13:22:18, Michael Achenbach wrote:
> Not sure if simulation of x32 would require target_arch=ia32? It's this 32 bit
user space in a 64 bit system, how would a simulator run. Do we even have one? I
think we recently dropped support for x32.

yeah, x32 should be deleted

[Michael Achenbach, 2016-06-08 13:29:35]

On 2016/06/08 13:24:29, jochen wrote:
> https://codereview.chromium.org/2045173003/diff/20001/Makefile
> File Makefile (right):
> 
> https://codereview.chromium.org/2045173003/diff/20001/Makefile#newcode255
> Makefile:255: ARCHES32 = ia32 x32 arm mips mipsel x87 ppc s390
> On 2016/06/08 at 13:22:18, Michael Achenbach wrote:
> > Not sure if simulation of x32 would require target_arch=ia32? It's this 32
bit
> user space in a 64 bit system, how would a simulator run. Do we even have one?
I
> think we recently dropped support for x32.
> 
> yeah, x32 should be deleted

Done

[jochen (gone - plz use gerrit), 2016-06-08 13:35:08]

lgtm

[Michael Achenbach, 2016-06-08 13:49:10]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-06-08 13:49:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045173003/40001

[commit-bot: I haz the power, 2016-06-08 13:51:17]

Description was changed from

==========
[build] Ensure target_arch is set correctly in toplevel Makefile

This sets the target_arch for simulator builds.

Fix needed for https://codereview.chromium.org/2028623002/

BUG=chromium:616032
NOTRY=true
==========

to

==========
[build] Ensure target_arch is set correctly in toplevel Makefile

This sets the target_arch for simulator builds.

Fix needed for https://codereview.chromium.org/2028623002/

BUG=chromium:616032
NOTRY=true
==========

[commit-bot: I haz the power, 2016-06-08 13:51:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-08 13:54:20]

Description was changed from

==========
[build] Ensure target_arch is set correctly in toplevel Makefile

This sets the target_arch for simulator builds.

Fix needed for https://codereview.chromium.org/2028623002/

BUG=chromium:616032
NOTRY=true
==========

to

==========
[build] Ensure target_arch is set correctly in toplevel Makefile

This sets the target_arch for simulator builds.

Fix needed for https://codereview.chromium.org/2028623002/

BUG=chromium:616032
NOTRY=true

Committed: https://crrev.com/0d4983fbb88b1a1453791778ce29967734bbb366
Cr-Commit-Position: refs/heads/master@{#36826}
==========

[commit-bot: I haz the power, 2016-06-08 13:54:21]

Patchset 3 (id:??) landed as
https://crrev.com/0d4983fbb88b1a1453791778ce29967734bbb366
Cr-Commit-Position: refs/heads/master@{#36826}