Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2028383002: Revert of Record offline histograms with suffix via Histogram::FactoryGet (Closed)

Created:
4 years, 6 months ago by jianli
Modified:
4 years, 6 months ago
Reviewers:
dimich, dewittj, mmenke, fgorski
CC:
chromium-reviews, cbentzel+watch_chromium.org, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Record offline histograms with suffix via Histogram::FactoryGet (patchset #5 id:80001 of https://codereview.chromium.org/2022283003/ ) Reason for revert: Need to revert this since the merge to M52 is very difficult without touching offline_page_model.cc. Will land this again with trivial change to offline_page_model.cc such that I can bring changes from offline_page_model_impl.cc to offline_page_model.cc in M52. Original issue's description: > Record offline histograms with suffix via Histogram::FactoryGet > > Also move all offline client namespace constants into one central place. > > BUG=616231 > TBR=mmenke@chromium.org > > Committed: https://crrev.com/8ccbcdc96179ab65038e17cdbddc149e28754830 > Cr-Commit-Position: refs/heads/master@{#397233} TBR=dimich@google.com,dewittj@chromium.org,mmenke@chromium.org,fgorski@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=616231 Committed: https://crrev.com/faeb6d3a51624f866bc590ef7d799933d88fc04f Cr-Commit-Position: refs/heads/master@{#397281}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -158 lines) Patch
M chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/offline_pages/offline_page_utils_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/net_error_tab_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/offline_pages.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/offline_pages/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D components/offline_pages/client_namespace_constants.h View 1 chunk +0 lines, -22 lines 0 comments Download
D components/offline_pages/client_namespace_constants.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M components/offline_pages/client_policy_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/offline_pages/client_policy_controller.cc View 1 chunk +8 lines, -1 line 0 comments Download
M components/offline_pages/client_policy_controller_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/offline_pages/offline_page_model.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/offline_pages/offline_page_model_impl.cc View 5 chunks +63 lines, -112 lines 0 comments Download
M components/offline_pages/offline_page_storage_manager_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jianli
Created Revert of Record offline histograms with suffix via Histogram::FactoryGet
4 years, 6 months ago (2016-06-01 23:26:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028383002/1
4 years, 6 months ago (2016-06-01 23:27:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 23:28:53 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 23:31:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/faeb6d3a51624f866bc590ef7d799933d88fc04f
Cr-Commit-Position: refs/heads/master@{#397281}

Powered by Google App Engine
This is Rietveld 408576698