Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: components/offline_pages/client_policy_controller.cc

Issue 2028383002: Revert of Record offline histograms with suffix via Histogram::FactoryGet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/client_policy_controller.h" 5 #include "components/offline_pages/client_policy_controller.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "components/offline_pages/client_namespace_constants.h"
11 10
12 using LifetimeType = offline_pages::LifetimePolicy::LifetimeType; 11 using LifetimeType = offline_pages::LifetimePolicy::LifetimeType;
13 12
14 namespace offline_pages { 13 namespace offline_pages {
15 14
15 namespace {
16 // TODO(romax): These should be moved to a centralized file.
17 // Any changes to these well-known namespaces should also be reflected in
18 // OfflinePagesNamespace (histograms.xml) for consistency.
19 const char kBookmarkNamespace[] = "bookmark";
20 const char kLastNNamespace[] = "last_n";
21 } // namespace
22
16 ClientPolicyController::ClientPolicyController() { 23 ClientPolicyController::ClientPolicyController() {
17 policies_.clear(); 24 policies_.clear();
18 // Manually defining client policies for bookmark and last_n. 25 // Manually defining client policies for bookmark and last_n.
19 policies_.insert(std::make_pair( 26 policies_.insert(std::make_pair(
20 kBookmarkNamespace, 27 kBookmarkNamespace,
21 MakePolicy(kBookmarkNamespace, LifetimeType::TEMPORARY, 28 MakePolicy(kBookmarkNamespace, LifetimeType::TEMPORARY,
22 base::TimeDelta::FromDays(7), kUnlimitedPages))); 29 base::TimeDelta::FromDays(7), kUnlimitedPages)));
23 policies_.insert(std::make_pair( 30 policies_.insert(std::make_pair(
24 kLastNNamespace, MakePolicy(kLastNNamespace, LifetimeType::TEMPORARY, 31 kLastNNamespace, MakePolicy(kLastNNamespace, LifetimeType::TEMPORARY,
25 base::TimeDelta::FromDays(2), 20))); 32 base::TimeDelta::FromDays(2), 20)));
(...skipping 19 matching lines...) Expand all
45 const OfflinePageClientPolicy& ClientPolicyController::GetPolicy( 52 const OfflinePageClientPolicy& ClientPolicyController::GetPolicy(
46 const std::string& name_space) const { 53 const std::string& name_space) const {
47 const auto& iter = policies_.find(name_space); 54 const auto& iter = policies_.find(name_space);
48 if (iter != policies_.end()) 55 if (iter != policies_.end())
49 return iter->second; 56 return iter->second;
50 // Fallback when the namespace isn't defined. 57 // Fallback when the namespace isn't defined.
51 return policies_.at(kDefaultNamespace); 58 return policies_.at(kDefaultNamespace);
52 } 59 }
53 60
54 } // namespace offline_pages 61 } // namespace offline_pages
OLDNEW
« no previous file with comments | « components/offline_pages/client_policy_controller.h ('k') | components/offline_pages/client_policy_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698