components/offline_pages/client_policy_controller.cc - Issue 2028383002: Revert of Record offline histograms with suffix via Histogram::FactoryGet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/client_policy_controller.cc

Issue 2028383002: Revert of Record offline histograms with suffix via Histogram::FactoryGet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/client_policy_controller.h ('k') | components/offline_pages/client_policy_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/client_policy_controller.cc

diff --git a/components/offline_pages/client_policy_controller.cc b/components/offline_pages/client_policy_controller.cc

index b8ccb0f679bb9cdf05d057f5f46ed163e28b7c63..04e8123ca9cac8113a74901e13d7730c576d3685 100644

--- a/components/offline_pages/client_policy_controller.cc

+++ b/components/offline_pages/client_policy_controller.cc

@@ -7,11 +7,18 @@

#include <utility>

#include "base/time/time.h"

-#include "components/offline_pages/client_namespace_constants.h"

using LifetimeType = offline_pages::LifetimePolicy::LifetimeType;

namespace offline_pages {

+namespace {

+// TODO(romax): These should be moved to a centralized file.

+// Any changes to these well-known namespaces should also be reflected in

+// OfflinePagesNamespace (histograms.xml) for consistency.

+const char kBookmarkNamespace[] = "bookmark";

+const char kLastNNamespace[] = "last_n";

+} // namespace

ClientPolicyController::ClientPolicyController() {

policies_.clear();