ServiceWorker: Distinguish SW.PageLoad w/ and w/o fetch handler

ServiceWorker: Distinguish SW.PageLoad w/ and w/o fetch handler

This patch separates ServiceWorker.PageLoad for serviceworker into the two: w/
and w/o fetch handler in order to measure the impact of the no-fetch handler
optimization.

BUG=605844
Committed: https://crrev.com/db1d53558883c7301360ddb05f0895fe05ae3408
Cr-Commit-Position: refs/heads/master@{#397060}

[shimazu, 2016-05-31 08:08:12]

shimazu@chromium.org changed reviewers:
+ falken@chromium.org, rkaplow@chromium.org

[shimazu, 2016-05-31 08:08:12]

PTAL:)

[falken, 2016-05-31 08:38:55]

looks good

https://codereview.chromium.org/2025813002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_metrics.cc (right):

https://codereview.chromium.org/2025813002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_metrics.cc:180: :
Site::WITHOUT_FETCH_HANDLER;
nit: prefer braces here for multi-line if body

https://codereview.chromium.org/2025813002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_metrics.h (right):

https://codereview.chromium.org/2025813002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_metrics.h:104: OTHER,
Add a comment that this is obsolete.

https://codereview.chromium.org/2025813002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2025813002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:86601: <int value="0" label="Other"/>
Add (unused) to Other

[shimazu, 2016-05-31 09:11:42]

Thanks, fixed these styles.

https://codereview.chromium.org/2025813002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_metrics.cc (right):

https://codereview.chromium.org/2025813002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_metrics.cc:180: :
Site::WITHOUT_FETCH_HANDLER;
On 2016/05/31 08:38:55, falken wrote:
> nit: prefer braces here for multi-line if body

Done.

https://codereview.chromium.org/2025813002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_metrics.h (right):

https://codereview.chromium.org/2025813002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_metrics.h:104: OTHER,
On 2016/05/31 08:38:55, falken wrote:
> Add a comment that this is obsolete.

Done.

https://codereview.chromium.org/2025813002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2025813002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:86601: <int value="0" label="Other"/>
On 2016/05/31 08:38:55, falken wrote:
> Add (unused) to Other

Done.

[rkaplow, 2016-05-31 13:54:48]

lgtm

[falken, 2016-05-31 14:25:20]

lgtm, thanks

[shimazu, 2016-06-01 02:14:16]

The CQ bit was checked by shimazu@chromium.org

[commit-bot: I haz the power, 2016-06-01 02:14:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2025813002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2025813002/40001

[commit-bot: I haz the power, 2016-06-01 02:16:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 02:16:52]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[shimazu, 2016-06-01 03:06:40]

The CQ bit was checked by shimazu@chromium.org

[shimazu, 2016-06-01 03:06:40]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org,
rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2025813002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-06-01 03:07:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2025813002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2025813002/60001

[commit-bot: I haz the power, 2016-06-01 04:55:02]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-01 04:56:04]

Description was changed from

==========
ServiceWorker: Distinguish SW.PageLoad w/ and w/o fetch handler

This patch separates ServiceWorker.PageLoad for serviceworker into the two: w/
and w/o fetch handler in order to measure the impact of the no-fetch handler
optimization.

BUG=605844
==========

to

==========
ServiceWorker: Distinguish SW.PageLoad w/ and w/o fetch handler

This patch separates ServiceWorker.PageLoad for serviceworker into the two: w/
and w/o fetch handler in order to measure the impact of the no-fetch handler
optimization.

BUG=605844

Committed: https://crrev.com/db1d53558883c7301360ddb05f0895fe05ae3408
Cr-Commit-Position: refs/heads/master@{#397060}
==========

[commit-bot: I haz the power, 2016-06-01 04:56:06]

Patchset 4 (id:??) landed as
https://crrev.com/db1d53558883c7301360ddb05f0895fe05ae3408
Cr-Commit-Position: refs/heads/master@{#397060}