Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: content/browser/service_worker/service_worker_controllee_request_handler.cc

Issue 2025813002: ServiceWorker: Distinguish SW.PageLoad w/ and w/o fetch handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_metrics.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_controllee_request_handler.cc
diff --git a/content/browser/service_worker/service_worker_controllee_request_handler.cc b/content/browser/service_worker/service_worker_controllee_request_handler.cc
index 1187e94b3c0af5e11cd92a30733303c54dd10fcc..20009afba0e21ab1186a6855269e4a22eff612d9 100644
--- a/content/browser/service_worker/service_worker_controllee_request_handler.cc
+++ b/content/browser/service_worker/service_worker_controllee_request_handler.cc
@@ -267,7 +267,8 @@ ServiceWorkerControlleeRequestHandler::DidLookupRegistrationForMainResource(
return;
}
- ServiceWorkerMetrics::CountControlledPageLoad(stripped_url_);
+ ServiceWorkerMetrics::CountControlledPageLoad(
+ stripped_url_, active_version->has_fetch_handler());
bool is_forwarded =
MaybeForwardToServiceWorker(job_.get(), active_version.get());
@@ -295,7 +296,8 @@ void ServiceWorkerControlleeRequestHandler::OnVersionStatusChanged(
return;
}
- ServiceWorkerMetrics::CountControlledPageLoad(stripped_url_);
+ ServiceWorkerMetrics::CountControlledPageLoad(stripped_url_,
+ version->has_fetch_handler());
provider_host_->AssociateRegistration(registration,
false /* notify_controllerchange */);
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_metrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698