Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: content/browser/service_worker/service_worker_metrics.cc

Issue 2025813002: ServiceWorker: Distinguish SW.PageLoad w/ and w/o fetch handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove comma Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/service_worker/service_worker_metrics.h" 5 #include "content/browser/service_worker/service_worker_metrics.h"
6 6
7 #include <limits> 7 #include <limits>
8 #include <string> 8 #include <string>
9 9
10 #include "base/metrics/histogram_macros.h" 10 #include "base/metrics/histogram_macros.h"
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 UMA_HISTOGRAM_SPARSE_SLOWLY("ServiceWorker.Storage.PurgeResourceResult", 165 UMA_HISTOGRAM_SPARSE_SLOWLY("ServiceWorker.Storage.PurgeResourceResult",
166 std::abs(net_error)); 166 std::abs(net_error));
167 } 167 }
168 168
169 void ServiceWorkerMetrics::RecordDeleteAndStartOverResult( 169 void ServiceWorkerMetrics::RecordDeleteAndStartOverResult(
170 DeleteAndStartOverResult result) { 170 DeleteAndStartOverResult result) {
171 UMA_HISTOGRAM_ENUMERATION("ServiceWorker.Storage.DeleteAndStartOverResult", 171 UMA_HISTOGRAM_ENUMERATION("ServiceWorker.Storage.DeleteAndStartOverResult",
172 result, NUM_DELETE_AND_START_OVER_RESULT_TYPES); 172 result, NUM_DELETE_AND_START_OVER_RESULT_TYPES);
173 } 173 }
174 174
175 void ServiceWorkerMetrics::CountControlledPageLoad(const GURL& url) { 175 void ServiceWorkerMetrics::CountControlledPageLoad(const GURL& url,
176 bool has_fetch_handler) {
176 Site site = SiteFromURL(url); 177 Site site = SiteFromURL(url);
178 if (site == Site::OTHER)
179 site = (has_fetch_handler) ? Site::WITH_FETCH_HANDLER
180 : Site::WITHOUT_FETCH_HANDLER;
falken 2016/05/31 08:38:55 nit: prefer braces here for multi-line if body
shimazu 2016/05/31 09:11:42 Done.
177 UMA_HISTOGRAM_ENUMERATION("ServiceWorker.PageLoad", static_cast<int>(site), 181 UMA_HISTOGRAM_ENUMERATION("ServiceWorker.PageLoad", static_cast<int>(site),
178 static_cast<int>(Site::NUM_TYPES)); 182 static_cast<int>(Site::NUM_TYPES));
179 183
180 if (ShouldExcludeSiteFromHistogram(site)) 184 if (ShouldExcludeSiteFromHistogram(site))
181 return; 185 return;
182 BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, 186 BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
183 base::Bind(&RecordURLMetricOnUI, url)); 187 base::Bind(&RecordURLMetricOnUI, url));
184 } 188 }
185 189
186 void ServiceWorkerMetrics::RecordStartWorkerStatus( 190 void ServiceWorkerMetrics::RecordStartWorkerStatus(
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
563 } else if (failure_count == 2) { 567 } else if (failure_count == 2) {
564 UMA_HISTOGRAM_ENUMERATION("ServiceWorker.StartWorker.AfterFailureStreak_2", 568 UMA_HISTOGRAM_ENUMERATION("ServiceWorker.StartWorker.AfterFailureStreak_2",
565 status, SERVICE_WORKER_ERROR_MAX_VALUE); 569 status, SERVICE_WORKER_ERROR_MAX_VALUE);
566 } else if (failure_count == 3) { 570 } else if (failure_count == 3) {
567 UMA_HISTOGRAM_ENUMERATION("ServiceWorker.StartWorker.AfterFailureStreak_3", 571 UMA_HISTOGRAM_ENUMERATION("ServiceWorker.StartWorker.AfterFailureStreak_3",
568 status, SERVICE_WORKER_ERROR_MAX_VALUE); 572 status, SERVICE_WORKER_ERROR_MAX_VALUE);
569 } 573 }
570 } 574 }
571 575
572 } // namespace content 576 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698