content/browser/service_worker/service_worker_metrics.h - Issue 2025813002: ServiceWorker: Distinguish SW.PageLoad w/ and w/o fetch handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_metrics.h

Issue 2025813002: ServiceWorker: Distinguish SW.PageLoad w/ and w/o fetch handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_controllee_request_handler.cc ('k') | content/browser/service_worker/service_worker_metrics.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_metrics.h

diff --git a/content/browser/service_worker/service_worker_metrics.h b/content/browser/service_worker/service_worker_metrics.h

index dd2372ad316cfdb951e9fc82e61debfc0e62eea2..1e9f2da3871bd69f8110f0f224f476a7e0ccb4e0 100644

--- a/content/browser/service_worker/service_worker_metrics.h

+++ b/content/browser/service_worker/service_worker_metrics.h

@@ -100,7 +100,13 @@ class ServiceWorkerMetrics {

};

// Used for UMA. Append only.

- enum class Site { OTHER, NEW_TAB_PAGE, NUM_TYPES };

+ enum class Site {

+ OTHER, // Obsolete

+ NEW_TAB_PAGE,

+ WITH_FETCH_HANDLER,

+ WITHOUT_FETCH_HANDLER,

+ NUM_TYPES

+ };

// Not used for UMA.

enum class StartSituation {

@@ -138,7 +144,7 @@ class ServiceWorkerMetrics {

static void RecordDeleteAndStartOverResult(DeleteAndStartOverResult result);

// Counts the number of page loads controlled by a Service Worker.

- static void CountControlledPageLoad(const GURL& url);

+ static void CountControlledPageLoad(const GURL& url, bool has_fetch_handler);

// Records the result of trying to start a worker. |is_installed| indicates

// whether the version has been installed.