[MD History] Add search for synced devices.

[MD History] Add search for synced devices.

This CL implements a simple search that matches the functionality of the
original history page.

This CL also fixes a bug related to window separators in the synced view
that could cause excess window separators to appear.

BUG=610934
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9f2348661c7b0fd695490cecbc4c3ef9f556b5df
Cr-Commit-Position: refs/heads/master@{#398252}

[calamity, 2016-05-31 05:37:23]

Description was changed from

==========
[MD History] Add search for synced devices.

This CL implements a simple search that matches the functionality of the
original history page.

This CL also fixes a bug related to window separators in the synced view
that could cause excess window separators to appear.

BUG=610934
==========

to

==========
[MD History] Add search for synced devices.

This CL implements a simple search that matches the functionality of the
original history page.

This CL also fixes a bug related to window separators in the synced view
that could cause excess window separators to appear.

BUG=610934
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-05-31 05:44:45]

Patchset #1 (id:1) has been deleted

[calamity, 2016-05-31 05:50:55]

Patchset #1 (id:20001) has been deleted

[calamity, 2016-05-31 05:51:45]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[calamity, 2016-05-31 05:51:45]

¯\_(ツ)_/¯

[tsergeant, 2016-06-01 08:00:35]

It would be good to highlight the search term in bold, as we do in the main
results list.

https://codereview.chromium.org/2022003002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_card.js (right):

https://codereview.chromium.org/2022003002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_card.js:35: separatorIndexes:
{
Nit: can use the one line short-form.

https://codereview.chromium.org/2022003002/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/history_synced_tabs_test.js (right):

https://codereview.chromium.org/2022003002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/history_synced_tabs_test.js:159:
element.searchedTerm = 'g';
Probably should `return flush()` (forces a new task + flush rather than a new
microtask).

[calamity, 2016-06-02 05:59:18]

Added a TODO for bolding the text.

https://codereview.chromium.org/2022003002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_card.js (right):

https://codereview.chromium.org/2022003002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_card.js:35: separatorIndexes:
{
On 2016/06/01 08:00:35, tsergeant wrote:
> Nit: can use the one line short-form.

Done.

https://codereview.chromium.org/2022003002/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/history_synced_tabs_test.js (right):

https://codereview.chromium.org/2022003002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/history_synced_tabs_test.js:159:
element.searchedTerm = 'g';
On 2016/06/01 08:00:35, tsergeant wrote:
> Probably should `return flush()` (forces a new task + flush rather than a new
> microtask).

Done.

[tsergeant, 2016-06-02 07:12:53]

lgtm w/ 2 nits

https://codereview.chromium.org/2022003002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_card.js (right):

https://codereview.chromium.org/2022003002/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_card.js:32: * The indexes
where a window separator should be shown.
Nit: It would be nice to try and explain why this method is used, since it's a
little unintuitive and subtle.

https://codereview.chromium.org/2022003002/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_card.js:79:
isWindowSeparatorIndex: function(index, separatorIndexes) {
Nit: Make this a private function.

[calamity, 2016-06-02 08:20:45]

https://codereview.chromium.org/2022003002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_card.js (right):

https://codereview.chromium.org/2022003002/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_card.js:32: * The indexes
where a window separator should be shown.
On 2016/06/02 07:12:53, tsergeant wrote:
> Nit: It would be nice to try and explain why this method is used, since it's a
> little unintuitive and subtle.

Done.

For those wondering, this was done to remove the old method of window separator
insertion which relied on modifying the sessionList elements. This would require
resetting and notifying each item. ensuring stale values are handled correctly.
Binding this array to the computed function provides a simpler notification
model since we don't have any stale value problems and are guaranteed to just
recompute everything when this array changes.

https://codereview.chromium.org/2022003002/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_card.js:79:
isWindowSeparatorIndex: function(index, separatorIndexes) {
On 2016/06/02 07:12:53, tsergeant wrote:
> Nit: Make this a private function.

Done.

[tsergeant, 2016-06-03 00:56:17]

https://codereview.chromium.org/2022003002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_card.js (right):

https://codereview.chromium.org/2022003002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_card.js:81:
isWindowSeparatorIndex_: function(index, separatorIndexes) {
Follow up nit since you need to rebase anyway:

/** @private */

[calamity, 2016-06-07 04:21:32]

The CQ bit was checked by calamity@chromium.org

[calamity, 2016-06-07 04:21:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2022003002/#ps100001
(title: "rebase, clang-format, add annotation")

[commit-bot: I haz the power, 2016-06-07 04:21:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2022003002/100001

[commit-bot: I haz the power, 2016-06-07 08:14:00]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-06-07 08:15:21]

Description was changed from

==========
[MD History] Add search for synced devices.

This CL implements a simple search that matches the functionality of the
original history page.

This CL also fixes a bug related to window separators in the synced view
that could cause excess window separators to appear.

BUG=610934
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Add search for synced devices.

This CL implements a simple search that matches the functionality of the
original history page.

This CL also fixes a bug related to window separators in the synced view
that could cause excess window separators to appear.

BUG=610934
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9f2348661c7b0fd695490cecbc4c3ef9f556b5df
Cr-Commit-Position: refs/heads/master@{#398252}
==========

[commit-bot: I haz the power, 2016-06-07 08:15:22]

Patchset 4 (id:??) landed as
https://crrev.com/9f2348661c7b0fd695490cecbc4c3ef9f556b5df
Cr-Commit-Position: refs/heads/master@{#398252}