[MD History] Create an icons.html for MD History.

[MD History] Create an icons.html for MD History.

This CL creates a smaller icons file for history rather than pulling in
all unnecessary icons in other packages.

BUG=605821
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6aa929611e6250d05017513eee4abed661842234
Cr-Commit-Position: refs/heads/master@{#396690}

[calamity, 2016-05-23 03:54:59]

Description was changed from

==========
[MD History] Create an icons.html for MD History.

This CL creates a smaller icons file for history rather than pulling in
all unnecessary icons in other packages.

BUG=None
==========

to

==========
[MD History] Create an icons.html for MD History.

This CL creates a smaller icons file for history rather than pulling in
all unnecessary icons in other packages.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-05-23 03:58:40]

Description was changed from

==========
[MD History] Create an icons.html for MD History.

This CL creates a smaller icons file for history rather than pulling in
all unnecessary icons in other packages.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Create an icons.html for MD History.

This CL creates a smaller icons file for history rather than pulling in
all unnecessary icons in other packages.

BUG=605821
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-05-24 07:54:48]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[tsergeant, 2016-05-25 04:33:20]

https://codereview.chromium.org/2001013002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/2001013002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_toolbar.html:11: <link rel="import"
href="chrome://history/icons.html">
Nit: Alphabetical order puts this above shared_style

https://codereview.chromium.org/2001013002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_toolbar.html:201: <paper-icon-button
icon="history:keyboard-arrow-left"
Probably should have caught this last review, but:

What's the difference between keyboard-arrow-left and chevron-left? I can't see
any difference and chevron-right is already in the shared icons file, so it
might be worth changing.

[calamity, 2016-05-25 05:59:25]

https://codereview.chromium.org/2001013002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/2001013002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_toolbar.html:11: <link rel="import"
href="chrome://history/icons.html">
On 2016/05/25 04:33:20, tsergeant wrote:
> Nit: Alphabetical order puts this above shared_style

Done.

https://codereview.chromium.org/2001013002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_toolbar.html:201: <paper-icon-button
icon="history:keyboard-arrow-left"
On 2016/05/25 04:33:19, tsergeant wrote:
> Probably should have caught this last review, but:
> 
> What's the difference between keyboard-arrow-left and chevron-left? I can't
see
> any difference and chevron-right is already in the shared icons file, so it
> might be worth changing.

Done.

[tsergeant, 2016-05-25 06:32:57]

🆒 lgtm

[calamity, 2016-05-25 06:49:48]

calamity@chromium.org changed reviewers:
+ dbeam@chromium.org

[calamity, 2016-05-25 06:49:49]

+dbeam for chrome/browser/browser_resources.grd and
ui/webui/resources/cr_elements/icons.html OWNERS

[tsergeant, 2016-05-25 06:49:53]

https://codereview.chromium.org/2001013002/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/icons.html (right):

https://codereview.chromium.org/2001013002/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/icons.html:20: <g id="chevron-left"><path
d="M15.41 7.41L14 6l-6 6 6 6 1.41-1.41L10.83 12z"></path></g>
Actually, this should move into history/icons.html, since it's not used anywhere
else.

[Dan Beam, 2016-05-25 18:11:41]

lgtm

i'll make you owners
this has gone on long enough
stupid grd, process

[calamity, 2016-05-26 01:48:22]

On 2016/05/25 18:11:41, Dan Beam wrote:
> lgtm
> 
> i'll make you owners
> this has gone on long enough
> stupid grd, process

cool, that'd be good
i'll miss the rubber stamping
and the mad haikus

[calamity, 2016-05-26 03:41:37]

The CQ bit was checked by calamity@chromium.org

[calamity, 2016-05-26 03:41:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2001013002/#ps40001
(title: "address comment")

[commit-bot: I haz the power, 2016-05-26 03:42:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2001013002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2001013002/40001

[commit-bot: I haz the power, 2016-05-26 04:19:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 04:19:16]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[calamity, 2016-05-26 04:34:54]

Patchset #3 (id:40001) has been deleted

[calamity, 2016-05-30 04:15:36]

Patchset #4 (id:80001) has been deleted

[calamity, 2016-05-30 06:57:22]

The CQ bit was checked by calamity@chromium.org

[calamity, 2016-05-30 06:57:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2001013002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-30 06:57:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2001013002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2001013002/100001

[commit-bot: I haz the power, 2016-05-30 07:02:09]

Description was changed from

==========
[MD History] Create an icons.html for MD History.

This CL creates a smaller icons file for history rather than pulling in
all unnecessary icons in other packages.

BUG=605821
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Create an icons.html for MD History.

This CL creates a smaller icons file for history rather than pulling in
all unnecessary icons in other packages.

BUG=605821
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-05-30 07:02:10]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-05-30 07:03:23]

Description was changed from

==========
[MD History] Create an icons.html for MD History.

This CL creates a smaller icons file for history rather than pulling in
all unnecessary icons in other packages.

BUG=605821
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Create an icons.html for MD History.

This CL creates a smaller icons file for history rather than pulling in
all unnecessary icons in other packages.

BUG=605821
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6aa929611e6250d05017513eee4abed661842234
Cr-Commit-Position: refs/heads/master@{#396690}
==========

[commit-bot: I haz the power, 2016-05-30 07:03:25]

Patchset 4 (id:??) landed as
https://crrev.com/6aa929611e6250d05017513eee4abed661842234
Cr-Commit-Position: refs/heads/master@{#396690}