Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2034473003: [MD History] Disable MD History for supervised users. (Closed)

Created:
4 years, 6 months ago by calamity
Modified:
4 years, 6 months ago
CC:
chromium-reviews, Patrick Dubroy, dbeam+watch-history_chromium.org, pam+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@hide_search_bar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Disable MD History for supervised users. This CL disables MD History for supervised users and users with grouped history enabled. This CL also fixes a bug where the groupByDomain variable didn't consider whether the user was a supervised user. BUG=589357 TBR=thestig@chromium.org Committed: https://crrev.com/20fc2afeeaa07903eb5bb610d1020fdbaa7a201e Cr-Commit-Position: refs/heads/master@{#398762}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix nit #

Patch Set 3 : fix android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -12 lines) Patch
M chrome/browser/browser_about_handler.cc View 1 2 2 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/md_history_ui.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/md_history_ui.cc View 3 chunks +12 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/uber/uber_ui.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 20 (10 generated)
calamity
4 years, 6 months ago (2016-06-02 08:23:21 UTC) #2
tsergeant
lgtm, assuming there's no pushback from Tom
4 years, 6 months ago (2016-06-03 03:28:12 UTC) #3
calamity
+dbeam for c/b/ui/webui OWNERS. TBR-ing thestig@ for browser_about_handler.cc
4 years, 6 months ago (2016-06-03 04:03:57 UTC) #5
Dan Beam
lgtm https://codereview.chromium.org/2034473003/diff/1/chrome/browser/ui/webui/uber/uber_ui.cc File chrome/browser/ui/webui/uber/uber_ui.cc (right): https://codereview.chromium.org/2034473003/diff/1/chrome/browser/ui/webui/uber/uber_ui.cc#newcode123 chrome/browser/ui/webui/uber/uber_ui.cc:123: profile->IsGuestSession()); unwrap
4 years, 6 months ago (2016-06-03 04:51:07 UTC) #7
Lei Zhang
On 2016/06/03 04:03:57, calamity wrote: > TBR-ing thestig@ for browser_about_handler.cc lgtm
4 years, 6 months ago (2016-06-06 22:30:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034473003/20001
4 years, 6 months ago (2016-06-08 00:50:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/78052)
4 years, 6 months ago (2016-06-08 01:07:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034473003/40001
4 years, 6 months ago (2016-06-09 01:42:45 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-09 02:03:13 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 02:04:40 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/20fc2afeeaa07903eb5bb610d1020fdbaa7a201e
Cr-Commit-Position: refs/heads/master@{#398762}

Powered by Google App Engine
This is Rietveld 408576698