Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2042973002: [MD History] Add routing to the synced devices page. (Closed)

Created:
4 years, 6 months ago by calamity
Modified:
4 years, 5 months ago
Reviewers:
tsergeant, michaelpg
CC:
chromium-reviews, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@hide_search_bar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Add routing to the history page. This CL adds app-route to the Material Design History page so that chrome://history/openTabs goes to the synced devices view and clicking the synced devices button in the sidebar also modifies the location bar. BUG=609502 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/357edd888ea83097acfec6125c6cb478d2499d03 Cr-Commit-Position: refs/heads/master@{#406488}

Patch Set 1 #

Patch Set 2 : #

Total comments: 14

Patch Set 3 : address comments #

Patch Set 4 : rebase #

Patch Set 5 : use 2-way mapping for routeData.page <=> selectedPage #

Patch Set 6 : remove unnecessary binding #

Patch Set 7 : remove a flush, save some water #

Patch Set 8 : privatize and clean up some properties #

Patch Set 9 : TODO for closure #

Patch Set 10 : #

Patch Set 11 : reimplement on top of list-container #

Patch Set 12 : fix test #

Total comments: 10

Patch Set 13 : address_comments #

Patch Set 14 : rebase #

Patch Set 15 : fix CBD button #

Patch Set 16 : fix_rebase #

Patch Set 17 : add comment #

Total comments: 11

Patch Set 18 : address comments #

Total comments: 1

Patch Set 19 : fix nit #

Total comments: 2

Patch Set 20 : remove app-route-converter #

Patch Set 21 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -23 lines) Patch
M chrome/browser/resources/md_history/app.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +14 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_history/app.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +41 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/compiled_resources2.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/history.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/side_bar.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +42 lines, -10 lines 0 comments Download
M chrome/browser/resources/md_history/side_bar.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +3 lines, -1 line 0 comments Download
A chrome/test/data/webui/md_history/history_routing_test.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +47 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_history/history_synced_tabs_test.js View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/webui/md_history/md_history_browsertest.js View 1 2 3 4 5 6 7 8 9 10 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/find_unused_elements.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -2 lines 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 2 chunks +30 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 36 (14 generated)
calamity
4 years, 6 months ago (2016-06-07 08:03:00 UTC) #4
tsergeant
Take my suggestions with a grain of salt, since I'm mostly going off the basics ...
4 years, 6 months ago (2016-06-08 03:42:18 UTC) #5
calamity
https://codereview.chromium.org/2042973002/diff/20001/chrome/browser/resources/md_history/app.html File chrome/browser/resources/md_history/app.html (right): https://codereview.chromium.org/2042973002/diff/20001/chrome/browser/resources/md_history/app.html#newcode10 chrome/browser/resources/md_history/app.html:10: <link rel="import" href="chrome://resources/polymer/v1_0/app-route/app-location.html"> On 2016/06/08 03:42:17, tsergeant wrote: > ...
4 years, 6 months ago (2016-06-14 05:05:50 UTC) #6
calamity
Reinstated selectedPage_ as discussed.
4 years, 6 months ago (2016-06-15 06:27:55 UTC) #7
calamity
Updated! PTAL, thanks.
4 years, 5 months ago (2016-07-13 06:30:03 UTC) #10
tsergeant
https://codereview.chromium.org/2042973002/diff/260001/chrome/browser/resources/md_history/app.js File chrome/browser/resources/md_history/app.js (right): https://codereview.chromium.org/2042973002/diff/260001/chrome/browser/resources/md_history/app.js#newcode209 chrome/browser/resources/md_history/app.js:209: getSelectedPage_(selectedPage, items) { If I understand correctly, this only ...
4 years, 5 months ago (2016-07-13 07:23:33 UTC) #11
calamity
https://codereview.chromium.org/2042973002/diff/260001/chrome/browser/resources/md_history/app.js File chrome/browser/resources/md_history/app.js (right): https://codereview.chromium.org/2042973002/diff/260001/chrome/browser/resources/md_history/app.js#newcode209 chrome/browser/resources/md_history/app.js:209: getSelectedPage_(selectedPage, items) { On 2016/07/13 07:23:33, tsergeant wrote: > ...
4 years, 5 months ago (2016-07-14 06:20:57 UTC) #13
tsergeant
https://codereview.chromium.org/2042973002/diff/360001/chrome/browser/resources/md_history/app.js File chrome/browser/resources/md_history/app.js (right): https://codereview.chromium.org/2042973002/diff/360001/chrome/browser/resources/md_history/app.js#newcode206 chrome/browser/resources/md_history/app.js:206: * fallback selection will continue to be used after ...
4 years, 5 months ago (2016-07-15 03:56:14 UTC) #14
Dan Beam
https://codereview.chromium.org/2042973002/diff/360001/chrome/browser/resources/md_history/app.js File chrome/browser/resources/md_history/app.js (right): https://codereview.chromium.org/2042973002/diff/360001/chrome/browser/resources/md_history/app.js#newcode206 chrome/browser/resources/md_history/app.js:206: * fallback selection will continue to be used after ...
4 years, 5 months ago (2016-07-15 04:23:41 UTC) #15
calamity
https://codereview.chromium.org/2042973002/diff/360001/chrome/browser/resources/md_history/app.js File chrome/browser/resources/md_history/app.js (right): https://codereview.chromium.org/2042973002/diff/360001/chrome/browser/resources/md_history/app.js#newcode206 chrome/browser/resources/md_history/app.js:206: * fallback selection will continue to be used after ...
4 years, 5 months ago (2016-07-15 06:22:02 UTC) #16
tsergeant
lgtm with 1 nit https://codereview.chromium.org/2042973002/diff/380001/chrome/browser/resources/md_history/side_bar.js File chrome/browser/resources/md_history/side_bar.js (right): https://codereview.chromium.org/2042973002/diff/380001/chrome/browser/resources/md_history/side_bar.js#newcode35 chrome/browser/resources/md_history/side_bar.js:35: * Relocates the user to ...
4 years, 5 months ago (2016-07-18 01:33:26 UTC) #17
calamity
+michaelpg for find_unused_elements.py and polymer_resources.grdp
4 years, 5 months ago (2016-07-18 04:54:54 UTC) #19
michaelpg
https://codereview.chromium.org/2042973002/diff/400001/ui/webui/resources/polymer_resources.grdp File ui/webui/resources/polymer_resources.grdp (right): https://codereview.chromium.org/2042973002/diff/400001/ui/webui/resources/polymer_resources.grdp#newcode47 ui/webui/resources/polymer_resources.grdp:47: <structure name="IDR_POLYMER_1_0_APP_ROUTE_APP_ROUTE_CONVERTER_EXTRACTED_JS" this & below seem to be unused
4 years, 5 months ago (2016-07-18 19:06:38 UTC) #20
calamity
https://codereview.chromium.org/2042973002/diff/400001/ui/webui/resources/polymer_resources.grdp File ui/webui/resources/polymer_resources.grdp (right): https://codereview.chromium.org/2042973002/diff/400001/ui/webui/resources/polymer_resources.grdp#newcode47 ui/webui/resources/polymer_resources.grdp:47: <structure name="IDR_POLYMER_1_0_APP_ROUTE_APP_ROUTE_CONVERTER_EXTRACTED_JS" On 2016/07/18 19:06:38, michaelpg wrote: > this ...
4 years, 5 months ago (2016-07-19 01:41:37 UTC) #21
calamity
On 2016/07/19 01:41:37, calamity wrote: > https://codereview.chromium.org/2042973002/diff/400001/ui/webui/resources/polymer_resources.grdp > File ui/webui/resources/polymer_resources.grdp (right): > > https://codereview.chromium.org/2042973002/diff/400001/ui/webui/resources/polymer_resources.grdp#newcode47 > ...
4 years, 5 months ago (2016-07-19 01:45:31 UTC) #22
michaelpg
lgtm
4 years, 5 months ago (2016-07-19 20:34:03 UTC) #23
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-20 01:54:15 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2042973002/440001
4 years, 5 months ago (2016-07-20 03:22:42 UTC) #31
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-20 03:22:44 UTC) #32
commit-bot: I haz the power
Committed patchset #21 (id:440001)
4 years, 5 months ago (2016-07-20 04:32:51 UTC) #33
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 04:32:56 UTC) #34
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 04:35:12 UTC) #36
Message was sent while issue was closed.
Patchset 21 (id:??) landed as
https://crrev.com/357edd888ea83097acfec6125c6cb478d2499d03
Cr-Commit-Position: refs/heads/master@{#406488}

Powered by Google App Engine
This is Rietveld 408576698