Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: cc/test/task_graph_runner_test_template.h

Issue 2021023002: cc: Rename CompleteOnOriginThread() -> OnTaskCompleted() in tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_notify_schedule_1
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | cc/test/task_graph_runner_test_template.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_TEST_TASK_GRAPH_RUNNER_TEST_TEMPLATE_H_ 5 #ifndef CC_TEST_TASK_GRAPH_RUNNER_TEST_TEMPLATE_H_
6 #define CC_TEST_TASK_GRAPH_RUNNER_TEST_TEMPLATE_H_ 6 #define CC_TEST_TASK_GRAPH_RUNNER_TEST_TEMPLATE_H_
7 7
8 #include "cc/raster/task_graph_runner.h" 8 #include "cc/raster/task_graph_runner.h"
9 9
10 #include <vector> 10 #include <vector>
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 56
57 protected: 57 protected:
58 class FakeTaskImpl : public Task { 58 class FakeTaskImpl : public Task {
59 public: 59 public:
60 FakeTaskImpl(TaskGraphRunnerTestBase* test, int namespace_index, int id) 60 FakeTaskImpl(TaskGraphRunnerTestBase* test, int namespace_index, int id)
61 : test_(test), namespace_index_(namespace_index), id_(id) {} 61 : test_(test), namespace_index_(namespace_index), id_(id) {}
62 62
63 // Overridden from Task: 63 // Overridden from Task:
64 void RunOnWorkerThread() override; 64 void RunOnWorkerThread() override;
65 65
66 // TODO(prashant.n): Rename this function to OnTaskCompleted() to make it 66 virtual void OnTaskCompleted();
67 // analogous with tile task. crbug.com/599863.
68 virtual void CompleteOnOriginThread();
69 67
70 protected: 68 protected:
71 ~FakeTaskImpl() override {} 69 ~FakeTaskImpl() override {}
72 70
73 private: 71 private:
74 TaskGraphRunnerTestBase* test_; 72 TaskGraphRunnerTestBase* test_;
75 int namespace_index_; 73 int namespace_index_;
76 int id_; 74 int id_;
77 75
78 DISALLOW_COPY_AND_ASSIGN(FakeTaskImpl); 76 DISALLOW_COPY_AND_ASSIGN(FakeTaskImpl);
79 }; 77 };
80 78
81 class FakeDependentTaskImpl : public FakeTaskImpl { 79 class FakeDependentTaskImpl : public FakeTaskImpl {
82 public: 80 public:
83 FakeDependentTaskImpl(TaskGraphRunnerTestBase* test, 81 FakeDependentTaskImpl(TaskGraphRunnerTestBase* test,
84 int namespace_index, 82 int namespace_index,
85 int id) 83 int id)
86 : FakeTaskImpl(test, namespace_index, id) {} 84 : FakeTaskImpl(test, namespace_index, id) {}
87 85
88 // Overridden from FakeTaskImpl: 86 // Overridden from FakeTaskImpl:
89 void CompleteOnOriginThread() override {} 87 void OnTaskCompleted() override {}
90 88
91 private: 89 private:
92 ~FakeDependentTaskImpl() override {} 90 ~FakeDependentTaskImpl() override {}
93 91
94 DISALLOW_COPY_AND_ASSIGN(FakeDependentTaskImpl); 92 DISALLOW_COPY_AND_ASSIGN(FakeDependentTaskImpl);
95 }; 93 };
96 94
97 TaskGraphRunner* task_graph_runner_; 95 TaskGraphRunner* task_graph_runner_;
98 NamespaceToken namespace_token_[kNamespaceCount]; 96 NamespaceToken namespace_token_[kNamespaceCount];
99 Task::Vector tasks_[kNamespaceCount]; 97 Task::Vector tasks_[kNamespaceCount];
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 EXPECT_EQ(1u, this->on_task_completed_ids(i)[0]); 291 EXPECT_EQ(1u, this->on_task_completed_ids(i)[0]);
294 EXPECT_EQ(0u, this->on_task_completed_ids(i)[1]); 292 EXPECT_EQ(0u, this->on_task_completed_ids(i)[1]);
295 } 293 }
296 } 294 }
297 295
298 REGISTER_TYPED_TEST_CASE_P(SingleThreadTaskGraphRunnerTest, Priority); 296 REGISTER_TYPED_TEST_CASE_P(SingleThreadTaskGraphRunnerTest, Priority);
299 297
300 } // namespace cc 298 } // namespace cc
301 299
302 #endif // CC_TEST_TASK_GRAPH_RUNNER_TEST_TEMPLATE_H_ 300 #endif // CC_TEST_TASK_GRAPH_RUNNER_TEST_TEMPLATE_H_
OLDNEW
« no previous file with comments | « no previous file | cc/test/task_graph_runner_test_template.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698