Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: cc/test/task_graph_runner_test_template.h

Issue 2021023002: cc: Rename CompleteOnOriginThread() -> OnTaskCompleted() in tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_notify_schedule_1
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/test/task_graph_runner_test_template.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/task_graph_runner_test_template.h
diff --git a/cc/test/task_graph_runner_test_template.h b/cc/test/task_graph_runner_test_template.h
index c58a71ad34abb3e5f1acbc48656be86cb0605c2b..01d1588a47bf1604d8f682735ea30d5d0ca53bef 100644
--- a/cc/test/task_graph_runner_test_template.h
+++ b/cc/test/task_graph_runner_test_template.h
@@ -63,9 +63,7 @@ class TaskGraphRunnerTestBase {
// Overridden from Task:
void RunOnWorkerThread() override;
- // TODO(prashant.n): Rename this function to OnTaskCompleted() to make it
- // analogous with tile task. crbug.com/599863.
- virtual void CompleteOnOriginThread();
+ virtual void OnTaskCompleted();
protected:
~FakeTaskImpl() override {}
@@ -86,7 +84,7 @@ class TaskGraphRunnerTestBase {
: FakeTaskImpl(test, namespace_index, id) {}
// Overridden from FakeTaskImpl:
- void CompleteOnOriginThread() override {}
+ void OnTaskCompleted() override {}
private:
~FakeDependentTaskImpl() override {}
« no previous file with comments | « no previous file | cc/test/task_graph_runner_test_template.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698