Issue 20209004: Turn on better popup blocker by default.

Issue 20209004: Turn on better popup blocker by default. (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 5 months ago

Reviewers:
marja

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Turn on better popup blocker by default. Can be turned off by --disable-better-popup-blocking BUG=38458 R=marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213802

Patch Set 2 : rebase #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -18 lines)			Patch
M	chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc	View	1	2 chunks	+6 lines, -2 lines	2 comments	Download
M	chrome/browser/ui/browser.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/browser_tab_contents.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser_tabstrip.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/content_settings/content_setting_bubble_model.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

marja

lgtm modulo https://codereview.chromium.org/20209004/diff/7001/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc File chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc (right): https://codereview.chromium.org/20209004/diff/7001/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc#newcode226 chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc:226: virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { This ...

7 years, 5 months ago (2013-07-25 13:42:51 UTC) #2

marja

https://codereview.chromium.org/20209004/diff/7001/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc File chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc (right): https://codereview.chromium.org/20209004/diff/7001/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc#newcode226 chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc:226: virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { On 2013/07/25 13:42:51, ...

7 years, 5 months ago (2013-07-25 13:47:10 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/20209004/7001

7 years, 5 months ago (2013-07-25 16:53:17 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/20209004/7001

7 years, 5 months ago (2013-07-26 02:51:53 UTC) #5

jochen (gone - plz use gerrit)

7 years, 5 months ago (2013-07-26 08:38:24 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r213802 (presubmit successful).

Expand Messages | Collapse Messages