Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6721)

Unified Diff: chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc

Issue 20209004: Turn on better popup blocker by default. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
diff --git a/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc b/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
index 2c1218937215d4dde508d32a845d6050e80430ba..3bf144d56ffbae292327d912db43af9e1f8d287f 100644
--- a/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
+++ b/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
@@ -74,6 +74,11 @@ class PopupBlockerBrowserTest : public InProcessBrowserTest {
public:
PopupBlockerBrowserTest() {}
+ virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
+ InProcessBrowserTest::SetUpCommandLine(command_line);
+ command_line->AppendSwitch(switches::kDisableBetterPopupBlocking);
+ }
+
// Returns a url that shows one popup.
GURL GetTestURL() {
return ui_test_utils::GetTestUrl(
@@ -219,8 +224,7 @@ class BetterPopupBlockerBrowserTest : public PopupBlockerBrowserTest {
virtual ~BetterPopupBlockerBrowserTest() {}
virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
marja 2013/07/25 13:42:51 This overridden func is now unnecessary.
marja 2013/07/25 13:47:11 I was fooled by the code! This is for bypassing th
- PopupBlockerBrowserTest::SetUpCommandLine(command_line);
- command_line->AppendSwitch(switches::kEnableBetterPopupBlocking);
+ InProcessBrowserTest::SetUpCommandLine(command_line);
}
private:
« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698