Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: chrome/browser/ui/browser.cc

Issue 20209004: Turn on better popup blocker by default. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 76a2810a30d0ab73dd6debbc94ed4b0f60bb9c44..2f983f5ae8fa8d7828be6534e6b22276233f744a 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1280,8 +1280,8 @@ WebContents* Browser::OpenURLFromTab(WebContents* source,
if (source)
popup_blocker_helper = PopupBlockerTabHelper::FromWebContents(source);
- if (CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableBetterPopupBlocking) &&
+ if (!CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kDisableBetterPopupBlocking) &&
popup_blocker_helper) {
if ((params.disposition == NEW_POPUP ||
@@ -1500,8 +1500,8 @@ bool Browser::ShouldCreateWebContents(
route_id, web_contents, frame_name, target_url);
}
- if (!CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableBetterPopupBlocking)) {
+ if (CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kDisableBetterPopupBlocking)) {
return true;
}

Powered by Google App Engine
This is Rietveld 408576698