chrome/browser/ui/browser_tab_contents.cc - Issue 20209004: Turn on better popup blocker by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_tab_contents.cc

Issue 20209004: Turn on better popup blocker by default. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_tab_contents.cc

diff --git a/chrome/browser/ui/browser_tab_contents.cc b/chrome/browser/ui/browser_tab_contents.cc

index e356025b08998824603f746e50d7799cca334c88..02c169168a455ae4914e8c7f352ba248aa7092d4 100644

--- a/chrome/browser/ui/browser_tab_contents.cc

+++ b/chrome/browser/ui/browser_tab_contents.cc

@@ -137,8 +137,8 @@ void BrowserTabContents::AttachTabHelpers(WebContents* web_contents) {

web_contents, PasswordManagerDelegateImpl::FromWebContents(web_contents));

PDFTabHelper::CreateForWebContents(web_contents);

PluginObserver::CreateForWebContents(web_contents);

- if (CommandLine::ForCurrentProcess()->HasSwitch(

- switches::kEnableBetterPopupBlocking)) {

+ if (!CommandLine::ForCurrentProcess()->HasSwitch(

+ switches::kDisableBetterPopupBlocking)) {

PopupBlockerTabHelper::CreateForWebContents(web_contents);

}

PrefsTabHelper::CreateForWebContents(web_contents);