Fix page transition qualifiers not masked out

Fix page transition qualifiers not masked out

I came across various examples of transition enum values being directly
compared against enum literals, without masking bits that represent
qualifiers.

Committed: https://crrev.com/225012b72cdb52b2dd5a6184583da74c8b500c23
Cr-Commit-Position: refs/heads/master@{#396898}

[mastiz, 2016-05-30 15:06:03]

Please review carefully, I came across this code and assumed the prior logic is
unintentional.

[mastiz, 2016-05-31 07:01:50]

mastiz@chromium.org changed reviewers:
+ droger@chromium.org, phajdan.jr@chromium.org, thestig@chromium.org

[mastiz, 2016-05-31 07:01:51]

Please review carefully, I came across this code and assumed the prior logic is
unintentional.

phajdan.jr@chromium.org: Please review changes in 
content/test

droger@chromium.org: Please review changes in 
components/translate

thestig@chromium.org: Please review changes in 
chrome/browser

[droger, 2016-05-31 07:52:38]

translate LGTM

[Paweł Hajdan Jr., 2016-05-31 14:14:41]

content/test LGTM

[Lei Zhang, 2016-05-31 17:54:48]

Description was changed from

==========
Fix page transition qualifiers not masked out

I came accross various examples of transition enum values being directly
compared against enum literals, without masking bits that represent
qualifiers.

For reviewers: please review carefully and let me know if you prefer
spliting to a dedicated patch.

BUG=
==========

to

==========
Fix page transition qualifiers not masked out

I came across various examples of transition enum values being directly
compared against enum literals, without masking bits that represent
qualifiers.
==========

[Lei Zhang, 2016-05-31 18:23:39]

LGTM

In a future CL, would you be interested in removing the #if that's preventing
the DontUseOperatorEquals check from being used outside of content?
https://code.google.com/p/chromium/codesearch#chromium/src/ui/base/page_trans...

[Lei Zhang, 2016-05-31 18:25:41]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-05-31 18:26:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2019373002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2019373002/20001

[commit-bot: I haz the power, 2016-05-31 19:45:59]

Description was changed from

==========
Fix page transition qualifiers not masked out

I came across various examples of transition enum values being directly
compared against enum literals, without masking bits that represent
qualifiers.
==========

to

==========
Fix page transition qualifiers not masked out

I came across various examples of transition enum values being directly
compared against enum literals, without masking bits that represent
qualifiers.
==========

[commit-bot: I haz the power, 2016-05-31 19:46:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-31 20:44:38]

Description was changed from

==========
Fix page transition qualifiers not masked out

I came across various examples of transition enum values being directly
compared against enum literals, without masking bits that represent
qualifiers.
==========

to

==========
Fix page transition qualifiers not masked out

I came across various examples of transition enum values being directly
compared against enum literals, without masking bits that represent
qualifiers.

Committed: https://crrev.com/225012b72cdb52b2dd5a6184583da74c8b500c23
Cr-Commit-Position: refs/heads/master@{#396898}
==========

[commit-bot: I haz the power, 2016-05-31 20:44:39]

Patchset 2 (id:??) landed as
https://crrev.com/225012b72cdb52b2dd5a6184583da74c8b500c23
Cr-Commit-Position: refs/heads/master@{#396898}