chrome/browser/ui/pdf/pdf_unsupported_feature.cc - Issue 2019373002: Fix page transition qualifiers not masked out

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/pdf/pdf_unsupported_feature.cc

Issue 2019373002: Fix page transition qualifiers not masked out (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added one more occurrence. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/pdf/pdf_unsupported_feature.cc

diff --git a/chrome/browser/ui/pdf/pdf_unsupported_feature.cc b/chrome/browser/ui/pdf/pdf_unsupported_feature.cc

index 9a317a3377bfa18a4fe5677981191898a2609a08..707a868ae39d41490f3cacfa554ccde627f35d25 100644

--- a/chrome/browser/ui/pdf/pdf_unsupported_feature.cc

+++ b/chrome/browser/ui/pdf/pdf_unsupported_feature.cc

@@ -97,7 +97,8 @@ bool PDFEnableAdobeReaderPromptClient::ShouldExpire(

ui::PageTransitionStripQualifier(details.entry->GetTransitionType());

// We don't want to expire on a reload, because that is how we open the PDF in

// Reader.

- return !details.is_in_page && transition != ui::PAGE_TRANSITION_RELOAD;

+ return !details.is_in_page &&

+ !ui::PageTransitionCoreTypeIs(transition, ui::PAGE_TRANSITION_RELOAD);

}

void PDFEnableAdobeReaderPromptClient::Accept() {