chrome/browser/ui/panels/panel_host.cc - Issue 2019373002: Fix page transition qualifiers not masked out

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_host.cc

Issue 2019373002: Fix page transition qualifiers not masked out (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added one more occurrence. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/panels/panel_host.cc

diff --git a/chrome/browser/ui/panels/panel_host.cc b/chrome/browser/ui/panels/panel_host.cc

index 6386d0bd5da2201773dec604bc0ac9ec577f16ce..d42e0b68ead728400ab44b8ea73d45e0027a743d 100644

--- a/chrome/browser/ui/panels/panel_host.cc

+++ b/chrome/browser/ui/panels/panel_host.cc

@@ -113,8 +113,10 @@ content::WebContents* PanelHost::OpenURLFromTab(

return NULL;

// Only allow clicks on links.

- if (params.transition != ui::PAGE_TRANSITION_LINK)

+ if (!ui::PageTransitionCoreTypeIs(params.transition,

+ ui::PAGE_TRANSITION_LINK)) {

return NULL;

+ }

// Force all links to open in a new tab.

chrome::NavigateParams navigate_params(profile_,