chrome/browser/ui/tabs/tab_strip_model_order_controller.cc - Issue 2019373002: Fix page transition qualifiers not masked out

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tabs/tab_strip_model_order_controller.cc

Issue 2019373002: Fix page transition qualifiers not masked out (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added one more occurrence. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/tabs/tab_strip_model_order_controller.cc

diff --git a/chrome/browser/ui/tabs/tab_strip_model_order_controller.cc b/chrome/browser/ui/tabs/tab_strip_model_order_controller.cc

index b91b34877dbe981cd9d4d6bd89ef17ddfa48cf16..4da7b98d5f6ae7ac29e21d249dc3ee3576cee64d 100644

--- a/chrome/browser/ui/tabs/tab_strip_model_order_controller.cc

+++ b/chrome/browser/ui/tabs/tab_strip_model_order_controller.cc

@@ -28,7 +28,7 @@ int TabStripModelOrderController::DetermineInsertionIndex(

// NOTE: TabStripModel enforces that all non-mini-tabs occur after mini-tabs,

// so we don't have to check here too.

- if (transition == ui::PAGE_TRANSITION_LINK &&

+ if (ui::PageTransitionCoreTypeIs(transition, ui::PAGE_TRANSITION_LINK) &&

tabstrip_->active_index() != -1) {

if (foreground) {

// If the page was opened in the foreground by a link click in another