cc/test/fake_tile_task_manager.cc - Issue 2018353005: cc: Fix data race in cc::TaskState::IsFinished.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/test/fake_tile_task_manager.cc

Issue 2018353005: cc: Fix data race in cc::TaskState::IsFinished. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: feedback Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/test/fake_tile_task_manager.cc

diff --git a/cc/test/fake_tile_task_manager.cc b/cc/test/fake_tile_task_manager.cc

index a5849eab488d874c598d3fd8906e822c82da5a32..cc7019897def8af11f5bb393f5a347bf07848368 100644

--- a/cc/test/fake_tile_task_manager.cc

+++ b/cc/test/fake_tile_task_manager.cc

@@ -34,6 +34,7 @@ void FakeTileTaskManagerImpl::CheckForCompletedTasks() {

DCHECK(task->state().IsFinished() || task->state().IsCanceled());

TileTask* tile_task = static_cast<TileTask*>(task.get());

tile_task->OnTaskCompleted();

+ tile_task->DidComplete();

}

completed_tasks_.clear();

« no previous file with comments | « cc/raster/tile_task.cc ('k') | cc/test/test_tile_task_runner.cc » ('j') | no next file with comments »