cc/test/test_tile_task_runner.cc - Issue 2018353005: cc: Fix data race in cc::TaskState::IsFinished.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/test/test_tile_task_runner.cc

Issue 2018353005: cc: Fix data race in cc::TaskState::IsFinished. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: feedback Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "cc/test/test_tile_task_runner.h"	5 #include "cc/test/test_tile_task_runner.h"

6	6

7 #include "base/logging.h"	7 #include "base/logging.h"

8	8

9 namespace cc {	9 namespace cc {

10	10

(...skipping 17 matching lines...) Expand all Loading...
28 DCHECK(task);	28 DCHECK(task);

29 task->state().DidStart();	29 task->state().DidStart();

30 task->RunOnWorkerThread();	30 task->RunOnWorkerThread();

31 task->state().DidFinish();	31 task->state().DidFinish();

32 }	32 }

33	33

34 void TestTileTaskRunner::CompleteTask(TileTask* task) {	34 void TestTileTaskRunner::CompleteTask(TileTask* task) {

35 DCHECK(task);	35 DCHECK(task);

36 DCHECK(task->state().IsFinished() \|\| task->state().IsCanceled());	36 DCHECK(task->state().IsFinished() \|\| task->state().IsCanceled());

37 task->OnTaskCompleted();	37 task->OnTaskCompleted();

	38 task->DidComplete();

38 }	39 }

39	40

40 } // namespace cc	41 } // namespace cc

OLD	NEW

« no previous file with comments | « cc/test/fake_tile_task_manager.cc ('k') | cc/tiles/tile_manager.cc » ('j') | no next file with comments »