Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2017893002: [Binding] [Refactoring] Use SerializedScriptValue class as external interface (Closed)

Created:
4 years, 7 months ago by peria
Modified:
4 years, 7 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, dtapuska+blinkwatch_chromium.org, Peter Beverloo, eae+blinkwatch, blink-reviews-events_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, cmumford, blink-reviews, kinuko+watch, jsbell+idb_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SerializedScriptValue class as external interface for (de)serialization. Before this CL, we use - SerializedScriptValueFactory::instance().create() to serialize values, and - serializedScriptValueInstance.deserialize() to deserialize it. and after this CL, we can use - SerializedScriptValue::serialize() to serialize values, and - serializedScriptValueInstance.deserialize() to deserialize it. Now users don't have to know SerializedScriptFactory to serialize values. BUG=614919 Committed: https://crrev.com/e409713897c7a798bd24981fcaeda7751e6cdaa0 Cr-Commit-Position: refs/heads/master@{#396438}

Patch Set 1 #

Patch Set 2 : Remove TODOs #

Total comments: 1

Patch Set 3 : Fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -46 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp View 2 chunks +17 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.h View 1 2 1 chunk +21 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueTest.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/V8ServiceWorkerMessageEventInternal.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_types.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/methods.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/EventSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSerializedScriptValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
peria
PTL
4 years, 7 months ago (2016-05-27 08:43:15 UTC) #3
haraken
LGTM
4 years, 7 months ago (2016-05-27 08:47:37 UTC) #4
Yuki
lgtm https://codereview.chromium.org/2017893002/diff/20001/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.h File third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.h (right): https://codereview.chromium.org/2017893002/diff/20001/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.h#newcode29 third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.h:29: friend class SerializedScriptValue; nit: This is a dup. ...
4 years, 7 months ago (2016-05-27 09:02:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017893002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017893002/60001
4 years, 7 months ago (2016-05-27 09:35:13 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 7 months ago (2016-05-27 11:15:27 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-27 11:16:40 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e409713897c7a798bd24981fcaeda7751e6cdaa0
Cr-Commit-Position: refs/heads/master@{#396438}

Powered by Google App Engine
This is Rietveld 408576698