third_party/WebKit/Source/web/tests/WebFrameTest.cpp - Issue 2017893002: [Binding] [Refactoring] Use SerializedScriptValue class as external interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2017893002: [Binding] [Refactoring] Use SerializedScriptValue class as external interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix build error Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

index 7e3ebf3f53a321af69e54cf5d2f07072a592e7e2..b2d4ad274c57325a801197399a9ac6e4980b9bcb 100644

--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

@@ -844,7 +844,7 @@ TEST_P(ParameterizedWebFrameTest, PostMessageThenDetach)

LocalFrame* frame = toLocalFrame(webViewHelper.webViewImpl()->page()->mainFrame());

NonThrowableExceptionState exceptionState;

MessagePortArray messagePorts;

- frame->domWindow()->postMessage(SerializedScriptValueFactory::instance().create("message"), messagePorts, "*", frame->localDOMWindow(), exceptionState);

+ frame->domWindow()->postMessage(SerializedScriptValue::serialize("message"), messagePorts, "*", frame->localDOMWindow(), exceptionState);

webViewHelper.reset();

EXPECT_FALSE(exceptionState.hadException());

« no previous file with comments | « third_party/WebKit/Source/web/WebSerializedScriptValue.cpp ('k') | no next file » | no next file with comments »