third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueTest.cpp - Issue 2017893002: [Binding] [Refactoring] Use SerializedScriptValue class as external interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueTest.cpp

Issue 2017893002: [Binding] [Refactoring] Use SerializedScriptValue class as external interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix build error Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueTest.cpp b/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueTest.cpp

index 53d491951a34aa1e7448ae81451af735e266383f..8a6677da481b22d684bb4c55d050a70294c1bce7 100644

--- a/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueTest.cpp

@@ -40,7 +40,7 @@ TEST_F(SerializedScriptValueTest, UserSelectedFile)

v8::Local<v8::Value> v8OriginalFile = toV8(originalFile, creationContext(), isolate());

RefPtr<SerializedScriptValue> serializedScriptValue =

- SerializedScriptValueFactory::instance().create(isolate(), v8OriginalFile, nullptr, nullptr, ASSERT_NO_EXCEPTION);

+ SerializedScriptValue::serialize(isolate(), v8OriginalFile, nullptr, nullptr, ASSERT_NO_EXCEPTION);

v8::Local<v8::Value> v8File = serializedScriptValue->deserialize(isolate());

ASSERT_TRUE(V8File::hasInstance(v8File, isolate()));