Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1602)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp

Issue 2017893002: [Binding] [Refactoring] Use SerializedScriptValue class as external interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix build error Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp
index 84e382e4184d1488a80fdd4a92cccb2718b82345..4c697ba7967e9756895b5bb9b05b4b036cf1d8e2 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp
@@ -57,7 +57,7 @@ static void storeDetail(ScriptState* scriptState, CustomEvent* impl, v8::Local<v
// |detail| and store it in |impl| so that we can clone |detail|
// when the getter of |detail| is called in the main world later.
if (DOMWrapperWorld::current(scriptState->isolate()).isIsolatedWorld())
- impl->setSerializedDetail(SerializedScriptValueFactory::instance().createAndSwallowExceptions(scriptState->isolate(), detail));
+ impl->setSerializedDetail(SerializedScriptValue::serializeAndSwallowExceptions(scriptState->isolate(), detail));
}
void V8CustomEvent::constructorCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -125,7 +125,7 @@ void V8CustomEvent::detailAttributeGetterCustom(const v8::FunctionCallbackInfo<v
} else if (DOMWrapperWorld::current(info.GetIsolate()).isIsolatedWorld()) {
v8::Local<v8::Value> mainWorldDetail = V8HiddenValue::getHiddenValueFromMainWorldWrapper(scriptState, event, V8HiddenValue::detail(info.GetIsolate()));
if (!mainWorldDetail.IsEmpty()) {
- event->setSerializedDetail(SerializedScriptValueFactory::instance().createAndSwallowExceptions(info.GetIsolate(), mainWorldDetail));
+ event->setSerializedDetail(SerializedScriptValue::serializeAndSwallowExceptions(info.GetIsolate(), mainWorldDetail));
detail = event->serializedDetail()->deserialize();
}
}

Powered by Google App Engine
This is Rietveld 408576698