Add functionality to the install_static library to tokenize strings and compare versions.

Add functionality to the install_static library to tokenize strings and compare versions.

This is required for the ongoing work to add crashpad integration in
chrome_elf and remove the crashpad integration from chrome.exe

As chrome_elf loads very early in the process, we cannot depend on
functionality from base which pulls in additional dependencies from
user32, etc.

I also added a target called install_static_unittests which contains tests
for the new functionality in install_static. The MatchPattern test has
been moved from chrome_elf to this executable.

The utf8_to_utf16 and utf16_to_utf8 functions in install_static are now public functions as they are
needed by crashpad.

The other changes in this patch are for getting the install_static
executable to run on the windows bots.

BUG=604923
TBR=dpranke

Committed: https://crrev.com/f2e54a999d4bd88062e27c61f995bac80cc025b1
Cr-Commit-Position: refs/heads/master@{#396612}

[ananta, 2016-05-27 02:17:08]

Description was changed from

==========
Add functionality to the install_static library to tokenize strings and compare
versions.

This is required for the ongoing work to add crashpad integration in
chrome_elf and remove the crashpad integration from chrome.exe

As chrome_elf loads very early in the process, we cannot depend on
functionality from base which pulls in additional dependencies from
user32, etc.

I also added a target called install_static_unittests which contains tests
for the new functionality in install_static. The MatchPattern test has
been moved from chrome_elf to this executable.

The other changes in this patch are for getting the install_static
executable to run on the windows bots.

BUG=604923
==========

to

==========
Add functionality to the install_static library to tokenize strings and compare
versions.

This is required for the ongoing work to add crashpad integration in
chrome_elf and remove the crashpad integration from chrome.exe

As chrome_elf loads very early in the process, we cannot depend on
functionality from base which pulls in additional dependencies from
user32, etc.

I also added a target called install_static_unittests which contains tests
for the new functionality in install_static. The MatchPattern test has
been moved from chrome_elf to this executable.

The other changes in this patch are for getting the install_static
executable to run on the windows bots.

BUG=604923
==========

[ananta, 2016-05-27 02:18:29]

Description was changed from

==========
Add functionality to the install_static library to tokenize strings and compare
versions.

This is required for the ongoing work to add crashpad integration in
chrome_elf and remove the crashpad integration from chrome.exe

As chrome_elf loads very early in the process, we cannot depend on
functionality from base which pulls in additional dependencies from
user32, etc.

I also added a target called install_static_unittests which contains tests
for the new functionality in install_static. The MatchPattern test has
been moved from chrome_elf to this executable.

The other changes in this patch are for getting the install_static
executable to run on the windows bots.

BUG=604923
==========

to

==========
Add functionality to the install_static library to tokenize strings and compare
versions.

This is required for the ongoing work to add crashpad integration in
chrome_elf and remove the crashpad integration from chrome.exe

As chrome_elf loads very early in the process, we cannot depend on
functionality from base which pulls in additional dependencies from
user32, etc.

I also added a target called install_static_unittests which contains tests
for the new functionality in install_static. The MatchPattern test has
been moved from chrome_elf to this executable.

The utf8_to_utf16 and utf16_to_utf8 functions in install_static are now public
functions as they are
needed by crashpad.

The other changes in this patch are for getting the install_static
executable to run on the windows bots.

BUG=604923
==========

[ananta, 2016-05-27 02:21:01]

ananta@chromium.org changed reviewers:
+ dpranke@chromium.org, grt@chromium.org, scottmg@chromium.org

[ananta, 2016-05-27 02:21:02]

dpranke for the buildbot stuff. Please check if the list of changes for adding
the install_static_unittests to the bots are correct.

scottmg, grt: Please review everything.

[grt (UTC plus 2), 2016-05-27 14:13:21]

round 1!

https://codereview.chromium.org/2017853002/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2017853002/diff/40001/BUILD.gn#newcode578
BUILD.gn:578: "//chrome/install_static:install_static_unittests",
i think this should be in src/build/gn_migration.gypi, too

https://codereview.chromium.org/2017853002/diff/40001/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/2017853002/diff/40001/build/all.gyp#newcode377
build/all.gyp:377: '../chrome/chrome.gyp:install_static_unittests',
move up to maintain ordering

https://codereview.chromium.org/2017853002/diff/40001/chrome/chrome_installer...
File chrome/chrome_installer_static.gypi (right):

https://codereview.chromium.org/2017853002/diff/40001/chrome/chrome_installer...
chrome/chrome_installer_static.gypi:50: 'target_name':
'install_static_unittests',
add an .isolate file for this test; see
http://www.chromium.org/developers/testing/isolated-testing/for-swes#TOC-Addi....
https://codereview.chromium.org/1223293004 is an example of a CL that makes
setup_unittests swarmable.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/B...
File chrome/install_static/BUILD.gn (right):

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/B...
chrome/install_static/BUILD.gn:36: "install_static_unittests.cc",
this source is testing functionality in install_util.{cc,h}, so please name it
install_util_unittest.cc (also, singular "unittest" is much more prevalent than
plural "unittests").

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
File chrome/install_static/install_static_unittests.cc (right):

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_static_unittests.cc:11: 
nit: put the tests in the install_static namespace and remove "install_static::"
below

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_static_unittests.cc:44: // Test if tokenize
returns the original string if an invalid token is
invalid token? this is actually testing a string containing only one token and
no delimiters, right?

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_static_unittests.cc:56: }
add tests for a string of all delimiters (e.g., "|||") and a string with some
empty tokens (e.g., "one|two||four").

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
File chrome/install_static/install_util.cc (right):

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:391: const char kWhiteSpaces[] = "
\t\n\r\f\v";
nit: constexpr

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:410: return std::all_of(str.begin(),
str.end(), ::isdigit);
as implemented, this will return true if std.empty(). should it not return false
instead?

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:737: std::string utf16_to_utf8(const
base::string16 &source) {
nit: & before space.  please use "git cl format" to catch these sorts of things.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:738: if (source.empty())
|| source.size() > std::numeric_limits<int>::max()

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:753: if (source.empty())
|| source.size() > std::numeric_limits<int>::max()

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:767: const char delimiter,
no const

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:788:
install_static::TokenizeString(version1, '.', false);
omit "install_static::"

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
File chrome/install_static/install_util.h (right):

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.h:12: #include <vector>
#include <string>

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.h:162: base::string16 utf8_to_utf16(const
std::string &source);
UTF8ToUTF16 (https://google.github.io/styleguide/cppguide.html#Function_Names)

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.h:170: const char delimiter,
nit: omit "const" for fundamental types

[scottmg, 2016-05-27 17:27:23]

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
File chrome/install_static/install_static_unittests.cc (right):

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_static_unittests.cc:97: }
maybe a test for sub-numbers that have leading 0s and a test for multiple digit
numbers (e.g. ".01." and ".20.").

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
File chrome/install_static/install_util.cc (right):

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:404: void trim(std::string* str) {
trim -> Trim

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:405: rtrim(str);
Seems like over-functioning since ltrim() and rtrim() are never used. Just put
the two erase() calls into Trim().

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:409: bool is_valid_number(const
std::string &str) {
IsValidNumber

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:768: bool trim_spaces) {
I only see trim_spaces=false calls other than in test code. Can we just get rid
of this argument and the related trim functions?

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:799: const size_t count =
std::min(version1_components.size(),
nit; weird line break

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:809: int version1_component =
std::stoi(version1_components[i]);
Ooh, this defaults to base=10, not =0, woohoo!

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
File chrome/install_static/install_util.h (right):

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.h:176: // -1 if version1 < version 2.
version 2 -> version2

[ananta, 2016-05-27 20:05:26]

https://codereview.chromium.org/2017853002/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2017853002/diff/40001/BUILD.gn#newcode578
BUILD.gn:578: "//chrome/install_static:install_static_unittests",
On 2016/05/27 14:13:20, grt (slow) wrote:
> i think this should be in src/build/gn_migration.gypi, too

Done.

https://codereview.chromium.org/2017853002/diff/40001/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/2017853002/diff/40001/build/all.gyp#newcode377
build/all.gyp:377: '../chrome/chrome.gyp:install_static_unittests',
On 2016/05/27 14:13:20, grt (slow) wrote:
> move up to maintain ordering

Done.

https://codereview.chromium.org/2017853002/diff/40001/chrome/chrome_installer...
File chrome/chrome_installer_static.gypi (right):

https://codereview.chromium.org/2017853002/diff/40001/chrome/chrome_installer...
chrome/chrome_installer_static.gypi:50: 'target_name':
'install_static_unittests',
On 2016/05/27 14:13:20, grt (slow) wrote:
> add an .isolate file for this test; see
>
http://www.chromium.org/developers/testing/isolated-testing/for-swes#TOC-Addi....
> https://codereview.chromium.org/1223293004 is an example of a CL that makes
> setup_unittests swarmable.

Yeah. I had that file created. Forgot to git add it. Done.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/B...
File chrome/install_static/BUILD.gn (right):

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/B...
chrome/install_static/BUILD.gn:36: "install_static_unittests.cc",
On 2016/05/27 14:13:20, grt (slow) wrote:
> this source is testing functionality in install_util.{cc,h}, so please name it
> install_util_unittest.cc (also, singular "unittest" is much more prevalent
than
> plural "unittests").

Done.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
File chrome/install_static/install_static_unittests.cc (right):

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_static_unittests.cc:11: 
On 2016/05/27 14:13:20, grt (slow) wrote:
> nit: put the tests in the install_static namespace and remove
"install_static::"
> below

Done.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_static_unittests.cc:44: // Test if tokenize
returns the original string if an invalid token is
On 2016/05/27 14:13:20, grt (slow) wrote:
> invalid token? this is actually testing a string containing only one token and
> no delimiters, right?

Rephrased.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_static_unittests.cc:56: }
On 2016/05/27 14:13:20, grt (slow) wrote:
> add tests for a string of all delimiters (e.g., "|||") and a string with some
> empty tokens (e.g., "one|two||four").

Done.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_static_unittests.cc:97: }
On 2016/05/27 17:27:22, scottmg wrote:
> maybe a test for sub-numbers that have leading 0s and a test for multiple
digit
> numbers (e.g. ".01." and ".20.").

Done.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
File chrome/install_static/install_util.cc (right):

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:391: const char kWhiteSpaces[] = "
\t\n\r\f\v";
On 2016/05/27 14:13:20, grt (slow) wrote:
> nit: constexpr

Done.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:404: void trim(std::string* str) {
On 2016/05/27 17:27:22, scottmg wrote:
> trim -> Trim

Done.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:405: rtrim(str);
On 2016/05/27 17:27:22, scottmg wrote:
> Seems like over-functioning since ltrim() and rtrim() are never used. Just put
> the two erase() calls into Trim().

Done.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:409: bool is_valid_number(const
std::string &str) {
On 2016/05/27 17:27:22, scottmg wrote:
> IsValidNumber

Done.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:410: return std::all_of(str.begin(),
str.end(), ::isdigit);
On 2016/05/27 14:13:20, grt (slow) wrote:
> as implemented, this will return true if std.empty(). should it not return
false
> instead?

Done.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:737: std::string utf16_to_utf8(const
base::string16 &source) {
On 2016/05/27 14:13:20, grt (slow) wrote:
> nit: & before space.  please use "git cl format" to catch these sorts of
things.

Yeah. I had done that. It seems every time I copy paste blocks in VS it
rearranges these things. Need to look for the option to turn it off.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:738: if (source.empty())
On 2016/05/27 14:13:20, grt (slow) wrote:
> || source.size() > std::numeric_limits<int>::max()

Done.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:753: if (source.empty())
On 2016/05/27 14:13:20, grt (slow) wrote:
> || source.size() > std::numeric_limits<int>::max()

Done.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:767: const char delimiter,
On 2016/05/27 14:13:20, grt (slow) wrote:
> no const

Done.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:768: bool trim_spaces) {
On 2016/05/27 17:27:22, scottmg wrote:
> I only see trim_spaces=false calls other than in test code. Can we just get
rid
> of this argument and the related trim functions?

Prefer to leave it as an argument. Just in case we need that functionality

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:788:
install_static::TokenizeString(version1, '.', false);
On 2016/05/27 14:13:20, grt (slow) wrote:
> omit "install_static::"

Done.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:799: const size_t count =
std::min(version1_components.size(),
On 2016/05/27 17:27:22, scottmg wrote:
> nit; weird line break

Done.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.cc:809: int version1_component =
std::stoi(version1_components[i]);
On 2016/05/27 17:27:22, scottmg wrote:
> Ooh, this defaults to base=10, not =0, woohoo!

Yeah

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
File chrome/install_static/install_util.h (right):

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.h:162: base::string16 utf8_to_utf16(const
std::string &source);
On 2016/05/27 14:13:20, grt (slow) wrote:
> UTF8ToUTF16 (https://google.github.io/styleguide/cppguide.html#Function_Names)

Done.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.h:170: const char delimiter,
On 2016/05/27 14:13:20, grt (slow) wrote:
> nit: omit "const" for fundamental types

Done.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.h:176: // -1 if version1 < version 2.
On 2016/05/27 17:27:22, scottmg wrote:
> version 2 -> version2

Done.

[grt (UTC plus 2), 2016-05-27 20:18:04]

https://codereview.chromium.org/2017853002/diff/40001/chrome/chrome_installer...
File chrome/chrome_installer_static.gypi (right):

https://codereview.chromium.org/2017853002/diff/40001/chrome/chrome_installer...
chrome/chrome_installer_static.gypi:50: 'target_name':
'install_static_unittests',
On 2016/05/27 20:05:25, ananta wrote:
> On 2016/05/27 14:13:20, grt (slow) wrote:
> > add an .isolate file for this test; see
> >
>
http://www.chromium.org/developers/testing/isolated-testing/for-swes#TOC-Addi....
> > https://codereview.chromium.org/1223293004 is an example of a CL that makes
> > setup_unittests swarmable.
> 
> Yeah. I had that file created. Forgot to git add it. Done.

Cool. You need an install_static_unittests_run target as well.

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
File chrome/install_static/install_util.h (right):

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.h:12: #include <vector>
On 2016/05/27 14:13:20, grt (slow) wrote:
> #include <string>

ping

https://codereview.chromium.org/2017853002/diff/80001/chrome/install_static/i...
File chrome/install_static/install_util.cc (right):

https://codereview.chromium.org/2017853002/diff/80001/chrome/install_static/i...
chrome/install_static/install_util.cc:562:
::GetEnvironmentVariable(UTF8ToUTF16(variable_name).c_str(), NULL, 0);
nullptr everywhere

[ananta, 2016-05-27 20:42:13]

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
File chrome/install_static/install_util.h (right):

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.h:12: #include <vector>
On 2016/05/27 20:18:03, grt (slow) wrote:
> On 2016/05/27 14:13:20, grt (slow) wrote:
> > #include <string>
> 
> ping

We get that through string16.h

https://codereview.chromium.org/2017853002/diff/80001/chrome/install_static/i...
File chrome/install_static/install_util.cc (right):

https://codereview.chromium.org/2017853002/diff/80001/chrome/install_static/i...
chrome/install_static/install_util.cc:562:
::GetEnvironmentVariable(UTF8ToUTF16(variable_name).c_str(), NULL, 0);
On 2016/05/27 20:18:04, grt (slow) wrote:
> nullptr everywhere

Done.

[grt (UTC plus 2), 2016-05-27 20:47:35]

lgtm

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
File chrome/install_static/install_util.h (right):

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.h:12: #include <vector>
On 2016/05/27 20:42:13, ananta wrote:
> On 2016/05/27 20:18:03, grt (slow) wrote:
> > On 2016/05/27 14:13:20, grt (slow) wrote:
> > > #include <string>
> > 
> > ping
> 
> We get that through string16.h

i think the rules of iwyu say that you shouldn't count on that.

[scottmg, 2016-05-27 20:57:59]

lgtm

https://codereview.chromium.org/2017853002/diff/100001/chrome/chrome_installe...
File chrome/chrome_installer_static.gypi (right):

https://codereview.chromium.org/2017853002/diff/100001/chrome/chrome_installe...
chrome/chrome_installer_static.gypi:80:
'install_static/install_static_unittests.isolate'
tabs here (rietveld's display of them is currently broken)

[ananta, 2016-05-27 21:38:54]

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
File chrome/install_static/install_util.h (right):

https://codereview.chromium.org/2017853002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.h:12: #include <vector>
On 2016/05/27 20:47:35, grt (slow) wrote:
> On 2016/05/27 20:42:13, ananta wrote:
> > On 2016/05/27 20:18:03, grt (slow) wrote:
> > > On 2016/05/27 14:13:20, grt (slow) wrote:
> > > > #include <string>
> > > 
> > > ping
> > 
> > We get that through string16.h
> 
> i think the rules of iwyu say that you shouldn't count on that.

ok. Added include

https://codereview.chromium.org/2017853002/diff/100001/chrome/chrome_installe...
File chrome/chrome_installer_static.gypi (right):

https://codereview.chromium.org/2017853002/diff/100001/chrome/chrome_installe...
chrome/chrome_installer_static.gypi:80:
'install_static/install_static_unittests.isolate'
On 2016/05/27 20:57:59, scottmg wrote:
> tabs here (rietveld's display of them is currently broken)

Done.

[ananta, 2016-05-28 00:21:44]

Description was changed from

==========
Add functionality to the install_static library to tokenize strings and compare
versions.

This is required for the ongoing work to add crashpad integration in
chrome_elf and remove the crashpad integration from chrome.exe

As chrome_elf loads very early in the process, we cannot depend on
functionality from base which pulls in additional dependencies from
user32, etc.

I also added a target called install_static_unittests which contains tests
for the new functionality in install_static. The MatchPattern test has
been moved from chrome_elf to this executable.

The utf8_to_utf16 and utf16_to_utf8 functions in install_static are now public
functions as they are
needed by crashpad.

The other changes in this patch are for getting the install_static
executable to run on the windows bots.

BUG=604923
==========

to

==========
Add functionality to the install_static library to tokenize strings and compare
versions.

This is required for the ongoing work to add crashpad integration in
chrome_elf and remove the crashpad integration from chrome.exe

As chrome_elf loads very early in the process, we cannot depend on
functionality from base which pulls in additional dependencies from
user32, etc.

I also added a target called install_static_unittests which contains tests
for the new functionality in install_static. The MatchPattern test has
been moved from chrome_elf to this executable.

The utf8_to_utf16 and utf16_to_utf8 functions in install_static are now public
functions as they are
needed by crashpad.

The other changes in this patch are for getting the install_static
executable to run on the windows bots.

BUG=604923
TBR=dpranke
==========

[ananta, 2016-05-28 00:22:09]

TBR'ing dpranke. Will address comments in a followup

[ananta, 2016-05-28 00:34:37]

The CQ bit was checked by ananta@chromium.org

[ananta, 2016-05-28 00:34:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
scottmg@chromium.org, grt@chromium.org
Link to the patchset: https://codereview.chromium.org/2017853002/#ps140001
(title: "Add install_static_unittests to other windows bots")

[commit-bot: I haz the power, 2016-05-28 00:35:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2017853002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2017853002/140001

[commit-bot: I haz the power, 2016-05-28 00:39:27]

Description was changed from

==========
Add functionality to the install_static library to tokenize strings and compare
versions.

This is required for the ongoing work to add crashpad integration in
chrome_elf and remove the crashpad integration from chrome.exe

As chrome_elf loads very early in the process, we cannot depend on
functionality from base which pulls in additional dependencies from
user32, etc.

I also added a target called install_static_unittests which contains tests
for the new functionality in install_static. The MatchPattern test has
been moved from chrome_elf to this executable.

The utf8_to_utf16 and utf16_to_utf8 functions in install_static are now public
functions as they are
needed by crashpad.

The other changes in this patch are for getting the install_static
executable to run on the windows bots.

BUG=604923
TBR=dpranke
==========

to

==========
Add functionality to the install_static library to tokenize strings and compare
versions.

This is required for the ongoing work to add crashpad integration in
chrome_elf and remove the crashpad integration from chrome.exe

As chrome_elf loads very early in the process, we cannot depend on
functionality from base which pulls in additional dependencies from
user32, etc.

I also added a target called install_static_unittests which contains tests
for the new functionality in install_static. The MatchPattern test has
been moved from chrome_elf to this executable.

The utf8_to_utf16 and utf16_to_utf8 functions in install_static are now public
functions as they are
needed by crashpad.

The other changes in this patch are for getting the install_static
executable to run on the windows bots.

BUG=604923
TBR=dpranke
==========

[commit-bot: I haz the power, 2016-05-28 00:39:29]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-05-28 00:41:07]

Description was changed from

==========
Add functionality to the install_static library to tokenize strings and compare
versions.

This is required for the ongoing work to add crashpad integration in
chrome_elf and remove the crashpad integration from chrome.exe

As chrome_elf loads very early in the process, we cannot depend on
functionality from base which pulls in additional dependencies from
user32, etc.

I also added a target called install_static_unittests which contains tests
for the new functionality in install_static. The MatchPattern test has
been moved from chrome_elf to this executable.

The utf8_to_utf16 and utf16_to_utf8 functions in install_static are now public
functions as they are
needed by crashpad.

The other changes in this patch are for getting the install_static
executable to run on the windows bots.

BUG=604923
TBR=dpranke
==========

to

==========
Add functionality to the install_static library to tokenize strings and compare
versions.

This is required for the ongoing work to add crashpad integration in
chrome_elf and remove the crashpad integration from chrome.exe

As chrome_elf loads very early in the process, we cannot depend on
functionality from base which pulls in additional dependencies from
user32, etc.

I also added a target called install_static_unittests which contains tests
for the new functionality in install_static. The MatchPattern test has
been moved from chrome_elf to this executable.

The utf8_to_utf16 and utf16_to_utf8 functions in install_static are now public
functions as they are
needed by crashpad.

The other changes in this patch are for getting the install_static
executable to run on the windows bots.

BUG=604923
TBR=dpranke

Committed: https://crrev.com/f2e54a999d4bd88062e27c61f995bac80cc025b1
Cr-Commit-Position: refs/heads/master@{#396612}
==========

[commit-bot: I haz the power, 2016-05-28 00:41:09]

Patchset 8 (id:??) landed as
https://crrev.com/f2e54a999d4bd88062e27c61f995bac80cc025b1
Cr-Commit-Position: refs/heads/master@{#396612}

[Nico, 2016-05-31 14:00:10]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-05-31 14:00:11]

this doesn't build in gyp builds:

[29574/34047] RULE install_static_unittests_run:
isolate_505e5a847558b720a0ef83d1cbafd202
install_static\install_static_unittests.isolate
FAILED: install_static_unittests.isolated.gen.json 
C:\b\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper
environment.x86
install_static_unittests_run_target_isolate_505e5a847558b720a0ef83d1cbafd202.8c6a326aa7c39f12a19f31e474b8425f.rsp
..\..\chrome
Traceback (most recent call last):

  File "../tools/isolate_driver.py", line 313, in <module>

    sys.exit(main())

  File "../tools/isolate_driver.py", line 297, in main

    create_wrapper(args, isolate, isolated)

  File "../tools/isolate_driver.py", line 212, in create_wrapper

    assert os.path.basename(isolate) == isolate, isolate

AssertionError: install_static\install_static_unittests.isolate

[Dirk Pranke, 2016-05-31 22:11:55]

https://codereview.chromium.org/2017853002/diff/140001/chrome/install_static/...
File chrome/install_static/BUILD.gn (right):

https://codereview.chromium.org/2017853002/diff/140001/chrome/install_static/...
chrome/install_static/BUILD.gn:34: output_name = "install_static_unittests"
output_name isn't needed here.

https://codereview.chromium.org/2017853002/diff/140001/chrome/install_static/...
chrome/install_static/BUILD.gn:38: include_dirs = [ "$target_gen_dir" ]
this shouldn't be needed, either.

https://codereview.chromium.org/2017853002/diff/140001/testing/buildbot/chrom...
File testing/buildbot/chromium_trybot.json (right):

https://codereview.chromium.org/2017853002/diff/140001/testing/buildbot/chrom...
testing/buildbot/chromium_trybot.json:214: "platforms": [
this file isn't actually used for anything and this change isn't needed, either.