Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6819)

Unified Diff: chrome_elf/chrome_elf_util_unittest.cc

Issue 2017853002: Add functionality to the install_static library to tokenize strings and compare versions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add install_static_unittests to other windows bots Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_elf/chrome_elf_util_unittest.cc
diff --git a/chrome_elf/chrome_elf_util_unittest.cc b/chrome_elf/chrome_elf_util_unittest.cc
index a41a5bcfc7a84bc89e1245aabc4d01cc51929461..210901e82106a9a39d916c12692a0c83f83b7a44 100644
--- a/chrome_elf/chrome_elf_util_unittest.cc
+++ b/chrome_elf/chrome_elf_util_unittest.cc
@@ -399,23 +399,4 @@ INSTANTIATE_TEST_CASE_P(GoogleChrome, ChromeElfUtilTest,
testing::Values("user", "system"),
testing::Values("single", "multi")));
-// Tests the MatchPattern function in the install_static library.
-// TODO(ananta)
-// Move this to install_static_unittests.
-// http://crbug.com/604923
-TEST(MiscUtilTest, InstallStaticMatchPattern) {
- EXPECT_TRUE(install_static::MatchPattern(L"", L""));
- EXPECT_TRUE(install_static::MatchPattern(L"", L"*"));
- EXPECT_FALSE(install_static::MatchPattern(L"", L"*a"));
- EXPECT_FALSE(install_static::MatchPattern(L"", L"abc"));
- EXPECT_TRUE(install_static::MatchPattern(L"Hello1234", L"He??o*1*"));
- EXPECT_TRUE(install_static::MatchPattern(L"Foo", L"F*?"));
- EXPECT_TRUE(install_static::MatchPattern(L"Foo", L"F*"));
- EXPECT_FALSE(install_static::MatchPattern(L"Foo", L"F*b"));
- EXPECT_TRUE(install_static::MatchPattern(L"abcd", L"*c*d"));
- EXPECT_TRUE(install_static::MatchPattern(L"abcd", L"*?c*d"));
- EXPECT_FALSE(install_static::MatchPattern(L"abcd", L"abcd*efgh"));
- EXPECT_TRUE(install_static::MatchPattern(L"foobarabc", L"*bar*"));
-}
-
} // namespace

Powered by Google App Engine
This is Rietveld 408576698