Swarm setup_unittests on FYI bots.

Swarm setup_unittests on FYI bots.

BUG=153829
Committed: https://crrev.com/804af0e8e9f81feab0cc56790a8b63032ed5fcd8
Cr-Commit-Position: refs/heads/master@{#339087}

[grt (UTC plus 2), 2015-07-13 20:11:28]

grt@chromium.org changed reviewers:
+ maruel@chromium.org

[grt (UTC plus 2), 2015-07-13 20:12:03]

Hi Marc-Antoine. I think I have setup_unittests building on the relevant bots
now, so
I'd like to start running it. Is this the right thing? I also have
https://codereview.chromium.org/1237693003/, but it's not clear to me if both
are
needed or not. Any advice would be appreciated. Thanks.

[M-A Ruel, 2015-07-13 20:26:00]

On 2015/07/13 20:12:03, grt wrote:
> Hi Marc-Antoine. I think I have setup_unittests building on the relevant bots
> now, so
> I'd like to start running it. Is this the right thing? I also have
> https://codereview.chromium.org/1237693003/, but it's not clear to me if both
> are
> needed or not. Any advice would be appreciated. Thanks.

You shouldn't need to update the factories, you can ignore the other CL.

https://codereview.chromium.org/1223293004/diff/1/testing/buildbot/chromium.w...
File testing/buildbot/chromium.win.json (right):

https://codereview.chromium.org/1223293004/diff/1/testing/buildbot/chromium.w...
testing/buildbot/chromium.win.json:241: "test": "setup_unittests"
Please have it run on swarming, otherwise you'll become a blocker for
http://crbug.com/496321.

[grt (UTC plus 2), 2015-07-13 20:54:17]

Tanks.

https://codereview.chromium.org/1223293004/diff/1/testing/buildbot/chromium.w...
File testing/buildbot/chromium.win.json (right):

https://codereview.chromium.org/1223293004/diff/1/testing/buildbot/chromium.w...
testing/buildbot/chromium.win.json:241: "test": "setup_unittests"
On 2015/07/13 20:26:00, M-A Ruel wrote:
> Please have it run on swarming, otherwise you'll become a blocker for
> http://crbug.com/496321.

This can't be as simple as "can_use_on_swarming_builders": true, can it? What do
I need to do to see if it actually works on swarming? .isolate-or-something? i
can haz pointer to instructions?

[M-A Ruel, 2015-07-13 22:29:58]

https://codereview.chromium.org/1223293004/diff/1/testing/buildbot/chromium.w...
File testing/buildbot/chromium.win.json (right):

https://codereview.chromium.org/1223293004/diff/1/testing/buildbot/chromium.w...
testing/buildbot/chromium.win.json:241: "test": "setup_unittests"
On 2015/07/13 20:54:17, grt wrote:
> On 2015/07/13 20:26:00, M-A Ruel wrote:
> > Please have it run on swarming, otherwise you'll become a blocker for
> > http://crbug.com/496321.
> 
> This can't be as simple as "can_use_on_swarming_builders": true, can it? What
do
> I need to do to see if it actually works on swarming? .isolate-or-something? i
> can haz pointer to instructions?

https://codereview.chromium.org/1220833004 is a good example.

[grt (UTC plus 2), 2015-07-14 15:27:18]

grt@chromium.org changed reviewers:
+ thakis@chromium.org

[grt (UTC plus 2), 2015-07-14 15:31:38]

Thanks for the pointer. I have no idea if this will work, but what the heck.
python tools/swarming_client/isolate.py run -s
out/Release/setup_unittests.isolated appears to work on my local machine. Let me
know if there's anything else I should verify before landing.

[grt (UTC plus 2), 2015-07-14 15:31:45]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[grt (UTC plus 2), 2015-07-14 15:31:52]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2015-07-14 15:32:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1223293004/40001

[commit-bot: I haz the power, 2015-07-14 15:49:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-14 15:49:40]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[M-A Ruel, 2015-07-14 18:30:26]

lgtm with one line removed if not necessary.

https://codereview.chromium.org/1223293004/diff/40001/chrome/setup_unittests....
File chrome/setup_unittests.isolate (right):

https://codereview.chromium.org/1223293004/diff/40001/chrome/setup_unittests....
chrome/setup_unittests.isolate:14: 'test/data/installer/',
Is this needed? If not, remove.

[grt (UTC plus 2), 2015-07-14 18:32:01]

Thanks.

https://codereview.chromium.org/1223293004/diff/40001/chrome/setup_unittests....
File chrome/setup_unittests.isolate (right):

https://codereview.chromium.org/1223293004/diff/40001/chrome/setup_unittests....
chrome/setup_unittests.isolate:14: 'test/data/installer/',
On 2015/07/14 18:30:26, M-A Ruel wrote:
> Is this needed? If not, remove.

procmon showed me that the test was reading file(s) from there, so i think it is
needed.

[grt (UTC plus 2), 2015-07-15 03:09:00]

Nico: ping for build/gn_migration.gypi OWNERS review. Thanks.

[Nico, 2015-07-15 17:08:22]

lgtm

[grt (UTC plus 2), 2015-07-15 18:00:21]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2015-07-15 18:00:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1223293004/40001

[commit-bot: I haz the power, 2015-07-15 20:29:16]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-07-15 20:30:22]

Patchset 2 (id:??) landed as
https://crrev.com/b398dec5088da75d3fbfb8d810c9b6f69ec7182a
Cr-Commit-Position: refs/heads/master@{#338902}

[Nico, 2015-07-16 14:53:51]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/1239083002/ by thakis@chromium.org.

The reason for reverting is: This seems to not work:
https://chromium-swarm.appspot.com/user/task/28ace3bc39b53310.

[grt (UTC plus 2), 2015-07-16 15:48:09]

On 2015/07/16 14:53:51, Nico wrote:
> A revert of this CL (patchset #2 id:40001) has been created in
> https://codereview.chromium.org/1239083002/ by mailto:thakis@chromium.org.
> 
> The reason for reverting is: This seems to not work:
> https://chromium-swarm.appspot.com/user/task/28ace3bc39b53310.

Thanks for the revert. I have a fix for the tests out for review. Hopefully
that'll take care of it.

[grt (UTC plus 2), 2015-07-16 17:32:31]

The CQ bit was checked by grt@chromium.org

[grt (UTC plus 2), 2015-07-16 17:32:31]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/1223293004/#ps60001
(title: "sync to position 339062 for reland")

[commit-bot: I haz the power, 2015-07-16 17:33:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1223293004/60001

[commit-bot: I haz the power, 2015-07-16 17:54:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-16 17:54:06]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

(exceeded global retry quota)

[grt (UTC plus 2), 2015-07-16 17:59:37]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2015-07-16 18:01:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1223293004/60001

[commit-bot: I haz the power, 2015-07-16 18:47:54]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-07-16 18:49:00]

Patchset 3 (id:??) landed as
https://crrev.com/804af0e8e9f81feab0cc56790a8b63032ed5fcd8
Cr-Commit-Position: refs/heads/master@{#339087}