Add functionality to the install_static library to tokenize strings and compare versions.

chrome/install_static/install_util.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 // This file contains helper functions which provide information about the
 // current version of Chrome. This includes channel information, version
 // information etc. This functionality is provided by using functions in
 // kernel32 and advapi32. No other dependencies are allowed in this file.
 
 #ifndef CHROME_INSTALL_STATIC_INSTALL_UTIL_H_
 #define CHROME_INSTALL_STATIC_INSTALL_UTIL_H_
 
+#include <vector>

[grt (UTC plus 2), 2016/05/27 14:13:20]

#include <string>

[grt (UTC plus 2), 2016/05/27 20:18:03]

ping

[ananta, 2016/05/27 20:42:13]

We get that through string16.h

[grt (UTC plus 2), 2016/05/27 20:47:35]

i think the rules of iwyu say that you shouldn't count on that.

[ananta, 2016/05/27 21:38:54]

ok. Added include

+
 #include "base/strings/string16.h"
 
 namespace install_static {
 
 enum class ProcessType {
   UNINITIALIZED,
   NON_BROWSER_PROCESS,
   BROWSER_PROCESS,
 };
 
@@ skipping 127 matching lines @@
 base::string16 GetBrowserCrashDumpAttemptsRegistryPath();
 
 // Returns true if the |source| string matches the |pattern|. The pattern
 // may contain wildcards like '?', which matches one character or a '*'
 // which matches 0 or more characters.
 // Please note that pattern matches the whole string. If you want to find
 // something in the middle of the string then you need to specify the pattern
 // as '*xyz*'.
 bool MatchPattern(const base::string16& source, const base::string16& pattern);
 
+// UTF8 to UTF16 and vice versa conversion helpers.
+base::string16 utf8_to_utf16(const std::string &source);

[grt (UTC plus 2), 2016/05/27 14:13:20]

UTF8ToUTF16 (https://google.github.io/styleguide/cppguide.html#Function_Names)

[ananta, 2016/05/27 20:05:26]

Done.

+
+std::string utf16_to_utf8(const base::string16 &source);
+
+// Tokenizes a string |str| based on single character delimiter.
+// The tokens are returned in a vector. The |trim_spaces| parameter indicates
+// whether the function should optionally trim spaces throughout the string.
+std::vector<std::string> TokenizeString(const std::string& str,
+                                        const char delimiter,

[grt (UTC plus 2), 2016/05/27 14:13:20]

nit: omit "const" for fundamental types

[ananta, 2016/05/27 20:05:26]

Done.

+                                        bool trim_spaces);
+
+// Compares version strings of the form "X.X.X.X" and returns the result of the
+// comparison in the |result| parameter. The result is as below:
+// 0 if the versions are equal.
+// -1 if version1 < version 2.

[scottmg, 2016/05/27 17:27:22]

version 2 -> version2

[ananta, 2016/05/27 20:05:26]

Done.

+// 1 if version1 > version2.
+// Returns true on success, false on invalid strings being passed, etc.
+bool CompareVersionStrings(const std::string& version1,
+                           const std::string& version2,
+                           int* result);
+
 // Caches the |ProcessType| of the current process.
 extern ProcessType g_process_type;
 
 }  // namespace install_static
 
 #endif  // CHROME_INSTALL_STATIC_INSTALL_UTIL_H_