Do not trigger new history entry if iframe URL doesn't change

Do not trigger new history entry if iframe URL doesn't change

When URL of an iframe changes from "unset" to "set", we don't want to
create new history entry. This worked for URLs without fragment
identifier but failed with it present.

This change takes the idea from the old code, before it was rewritten
in https://codereview.chromium.org/126453005

BUG=353096
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169665

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169736

[Nate Chapin, 2014-03-17 17:10:29]

LGTM

Any hope of a test so I don't regress this again in the future? :)

[Rafał Chłodnicki, 2014-03-18 20:27:01]

New tests failed due this difference:
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_dbg/...
Not sure why I get different dump locally but dropped frame id and using
querySelector now to hopefully fix it.

[Rafał Chłodnicki, 2014-03-20 09:09:07]

Still looks good with added tests?

[Nate Chapin, 2014-03-20 16:02:55]

On 2014/03/20 09:09:07, Rafał Chłodnicki wrote:
> Still looks good with added tests?

Yep. LGTM.

[Rafał Chłodnicki, 2014-03-20 16:04:48]

The CQ bit was checked by rchlodnicki@opera.com

[commit-bot: I haz the power, 2014-03-20 16:04:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rchlodnicki@opera.com/201773002/40001

[commit-bot: I haz the power, 2014-03-20 16:48:30]

Change committed as 169665

[eseidel, 2014-03-21 07:19:34]

A revert of this CL has been created in
https://codereview.chromium.org/207683003/ by eseidel@chromium.org.

The reason for reverting is: This may have broken browser_tests:
http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%2....

[vsevik, 2014-03-21 07:58:40]

On 2014/03/21 07:19:34, eseidel wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/207683003/ by mailto:eseidel@chromium.org.
> 
> The reason for reverting is: This may have broken browser_tests:
>
http://build.chromium.org/p/chromium.webkit/builders/Linux%2520Tests%2520%252....

I believe https://codereview.chromium.org/187103002/ was the actual culprit, so
feel free
to reland. was the actual culprit so feel free to reland.

[Rafał Chłodnicki, 2014-03-21 08:41:52]

On 2014/03/21 07:58:40, vsevik wrote:
> On 2014/03/21 07:19:34, eseidel wrote:
> > A revert of this CL has been created in
> > https://codereview.chromium.org/207683003/ by mailto:eseidel@chromium.org.
> > 
> > The reason for reverting is: This may have broken browser_tests:
> >
>
http://build.chromium.org/p/chromium.webkit/builders/Linux%252520Tests%252520....
> 
> I believe https://codereview.chromium.org/187103002/ was the actual culprit,
so
> feel free
> to reland. was the actual culprit so feel free to reland.

How to reland? Commit checkbox is disabled. Do I need to create new review for
the same changes?

[Rafał Chłodnicki, 2014-03-21 13:08:03]

The CQ bit was checked by rchlodnicki@opera.com

[commit-bot: I haz the power, 2014-03-21 13:08:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rchlodnicki@opera.com/201773002/40001

[commit-bot: I haz the power, 2014-03-21 13:08:53]

Change committed as 169736