Source/core/loader/FrameLoader.h - Issue 201773002: Do not trigger new history entry if iframe URL doesn't change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FrameLoader.h

Issue 201773002: Do not trigger new history entry if iframe URL doesn't change (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix tests. Somehow getting different iframe dump on some bots. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/history/history-length-append-subframe-with-hash-expected.txt ('k') | Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/loader/FrameLoader.h

diff --git a/Source/core/loader/FrameLoader.h b/Source/core/loader/FrameLoader.h

index 5d0ffaac3abc97156b1a8545ddaeea5bd6926100..9bf63cf23e18f86cc0315ee0944c5494bf9ab9a8 100644

--- a/Source/core/loader/FrameLoader.h

+++ b/Source/core/loader/FrameLoader.h

@@ -123,6 +123,7 @@ public:

bool isLoadingMainFrame() const;

+ bool shouldTreatURLAsSameAsCurrent(const KURL&) const;

bool shouldTreatURLAsSrcdocDocument(const KURL&) const;

FrameLoadType loadType() const;