Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 207683003: Revert of Do not trigger new history entry if iframe URL doesn't change (Closed)

Created:
6 years, 9 months ago by eseidel
Modified:
6 years, 9 months ago
CC:
blink-reviews, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Do not trigger new history entry if iframe URL doesn't change (https://codereview.chromium.org/201773002/) Reason for revert: This may have broken browser_tests: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2034/steps/browser_tests/logs/TabDestroyed Original issue's description: > Do not trigger new history entry if iframe URL doesn't change > > When URL of an iframe changes from "unset" to "set", we don't want to > create new history entry. This worked for URLs without fragment > identifier but failed with it present. > > This change takes the idea from the old code, before it was rewritten > in https://codereview.chromium.org/126453005 > > BUG=353096 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169665 TBR=abarth@chromium.org,japhet@chromium.org,rchlodnicki@opera.com NOTREECHECKS=true NOTRY=true BUG=353096 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169723

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -143 lines) Patch
D LayoutTests/fast/history/history-length-append-subframe-no-hash.html View 1 chunk +0 lines, -53 lines 0 comments Download
D LayoutTests/fast/history/history-length-append-subframe-no-hash-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/history/history-length-append-subframe-with-hash.html View 1 chunk +0 lines, -53 lines 0 comments Download
D LayoutTests/fast/history/history-length-append-subframe-with-hash-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M Source/core/loader/FrameLoader.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
Created Revert of Do not trigger new history entry if iframe URL doesn't change
6 years, 9 months ago (2014-03-21 07:19:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/207683003/1
6 years, 9 months ago (2014-03-21 07:20:17 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 07:20:36 UTC) #3
Message was sent while issue was closed.
Change committed as 169723

Powered by Google App Engine
This is Rietveld 408576698