Issue 126453005: Simplify starting a same-document navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126453005: Simplify starting a same-document navigation (Closed)

Created:
6 years, 11 months ago by Nate Chapin

Modified:
6 years, 11 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Simplify starting a same-document navigation * Don't bother checking navigation policy for a same document navigation, since the answer will always be yes and we already skip calling out to the embedder. * Remove FrameLoader's checkNavigationPolicyAndContinueFragmentScroll() and spread it across load() (which calls it) and loadInSameDocument (which it calls). * Use the UpdateBackForwardListPolicy as a parameter to loadInSameDocument instead of the boolean isNewNavigation. * Properly set ClientRedirectPolicy in NavigationScheduler::scheduleLocationChange, so that loadInSameDocument doesn't have to patch it up later. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164887

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -42 lines)			Patch
M	Source/core/loader/DocumentLoader.h	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
M	Source/core/loader/DocumentLoader.cpp	View	1	3 chunks	+3 lines, -4 lines	0 comments	Download
M	Source/core/loader/FrameLoader.h	View	1	2 chunks	+1 line, -3 lines	0 comments	Download
M	Source/core/loader/FrameLoader.cpp	View		6 chunks	+20 lines, -29 lines	0 comments	Download
M	Source/core/loader/NavigationScheduler.cpp	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/126453005/80001

6 years, 11 months ago (2014-01-10 17:28:43 UTC) #3

Message was sent while issue was closed.

Change committed as 164887

Expand Messages | Collapse Messages