Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2017153002: Add interesting features to visualize_color_gamut (Closed)

Created:
4 years, 6 months ago by msarett
Modified:
4 years, 6 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add interesting features to visualize_color_gamut (1) Draw triangles onto a D50 color gamut so they are actually in the correct place. (2) Add options to display canonical sRGB and Adobe RGB gamuts. (3) Label the R, G, and B points of the color gamut. (4) Decode and reencode the input image without color correction, so we can compare to the corrected version. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2017153002 Committed: https://skia.googlesource.com/skia/+/97205a4b419e0b7b1864db1945c4098c01874bbc

Patch Set 1 : Experiment with Bradford matrix #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Pass in reencoded image path as flag #

Patch Set 4 : Win compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -43 lines) Patch
M resources/gamut.png View 1 Binary file 0 comments Download
M tools/visualize_color_gamut.cpp View 1 2 3 3 chunks +109 lines, -43 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
msarett
4 years, 6 months ago (2016-05-27 19:54:27 UTC) #5
jcgregorio
https://codereview.chromium.org/2017153002/diff/40001/tools/visualize_color_gamut.cpp File tools/visualize_color_gamut.cpp (right): https://codereview.chromium.org/2017153002/diff/40001/tools/visualize_color_gamut.cpp#newcode187 tools/visualize_color_gamut.cpp:187: SkString path(input); The output path for the uncorrected input ...
4 years, 6 months ago (2016-05-27 20:00:38 UTC) #6
msarett
https://codereview.chromium.org/2017153002/diff/40001/tools/visualize_color_gamut.cpp File tools/visualize_color_gamut.cpp (right): https://codereview.chromium.org/2017153002/diff/40001/tools/visualize_color_gamut.cpp#newcode187 tools/visualize_color_gamut.cpp:187: SkString path(input); On 2016/05/27 20:00:38, jcgregorio wrote: > The ...
4 years, 6 months ago (2016-05-27 20:30:59 UTC) #7
jcgregorio
lgtm
4 years, 6 months ago (2016-05-27 20:32:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017153002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017153002/60001
4 years, 6 months ago (2016-05-27 20:33:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/8854)
4 years, 6 months ago (2016-05-27 20:40:35 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017153002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017153002/80001
4 years, 6 months ago (2016-05-27 20:44:03 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 20:56:55 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017153002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017153002/80001
4 years, 6 months ago (2016-05-27 20:57:34 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 21:01:07 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://skia.googlesource.com/skia/+/97205a4b419e0b7b1864db1945c4098c01874bbc

Powered by Google App Engine
This is Rietveld 408576698