PrerenderingLoader initial integration with PrerenderManager/PrerenderHandle and make it unit-testa…

PrerenderingLoader initial integration with PrerenderManager/PrerenderHandle and make it unit-testable.

[Note: this CL landed and was reverted per test failure reported in issue 614699.]

It proved challenging to write unittests wrt mocking PrerenderManager and/or PrerenderHandler and be able to create a stub PrerenderHandler without touching the prerender stack code so this CL takes the approach of adding an adapter between the Loader and prerender stack calls so that they can be intercepted for testing.

BTW, PrerenderingLoader is actually the "BackgroundLoader" of go/chrome-background-loading

TBR=fgorski@chromium.org,petewil@chromium.org,pasko@chromium.org,gabadie@chromium.org
BUG=601173, 614699
Committed: https://crrev.com/8ed74fd7c401a1ff9a5a57c270409e0f66f6d3ce
Cr-Commit-Position: refs/heads/master@{#395485}

patch from issue 1968593002 at patchset 420001 (http://crrev.com/1968593002#ps420001)

Committed: https://crrev.com/bd2f237c4acbdd9e0f6495b688f2c3da86127cac
Cr-Commit-Position: refs/heads/master@{#396191}

[dougarnett, 2016-05-25 19:10:24]

Description was changed from

==========
PrerenderingLoader initial integration with PrerenderManager/PrerenderHandle and
make it unit-testable.

[Note: this CL landed and was reverted per test failure reported in issue
614699.]

It proved challenging to write unittests wrt mocking PrerenderManager and/or
PrerenderHandler and be able to create a stub PrerenderHandler without touching
the prerender stack code so this CL takes the approach of adding an adapter
between the Loader and prerender stack calls so that they can be intercepted for
testing.

BTW, PrerenderingLoader is actually the "BackgroundLoader" of
go/chrome-background-loading

TBR=fgorski@chromium.org,petewil@chromium.org,pasko@chromium.org,gabadie@chro...
BUG=601173

Committed: https://crrev.com/8ed74fd7c401a1ff9a5a57c270409e0f66f6d3ce
Cr-Commit-Position: refs/heads/master@{#395485}

patch from issue 1968593002 at patchset 420001
(http://crrev.com/1968593002#ps420001)
==========

to

==========
PrerenderingLoader initial integration with PrerenderManager/PrerenderHandle and
make it unit-testable.

[Note: this CL landed and was reverted per test failure reported in issue
614699.]

It proved challenging to write unittests wrt mocking PrerenderManager and/or
PrerenderHandler and be able to create a stub PrerenderHandler without touching
the prerender stack code so this CL takes the approach of adding an adapter
between the Loader and prerender stack calls so that they can be intercepted for
testing.

BTW, PrerenderingLoader is actually the "BackgroundLoader" of
go/chrome-background-loading

TBR=fgorski@chromium.org,petewil@chromium.org,pasko@chromium.org,gabadie@chro...
BUG=601173,614699

Committed: https://crrev.com/8ed74fd7c401a1ff9a5a57c270409e0f66f6d3ce
Cr-Commit-Position: refs/heads/master@{#395485}

patch from issue 1968593002 at patchset 420001
(http://crrev.com/1968593002#ps420001)
==========

[dougarnett, 2016-05-25 19:45:40]

Working on re-landing the PrerenderingLoader change. Seems to be an issue with
not initializing some bool members of the TestAdapter. 

Patch Set 1 is original change and Patch Set 2 address the initialization issue.
I had trybot "asan-clang-phone" scheduled for both patch sets but it hasn't
started yet.

[Pete Williamson, 2016-05-25 19:50:03]

lgtm - All changes from the original patch look good to me.

[dougarnett, 2016-05-25 23:01:16]

Fyi, waiting for the asan-clang-phone trybot to start and run. It shows as
scheduled. Looks like it takes many hours to run (once it does start).

[pasko, 2016-05-26 10:54:23]

lgtm

On 2016/05/25 23:01:16, dougarnett wrote:
> Fyi, waiting for the asan-clang-phone trybot to start and run. It shows as
> scheduled. Looks like it takes many hours to run (once it does start).

Don't hesitate to land without results from this trybot. I am not sure the
trybot is actually supported.

[dougarnett, 2016-05-26 14:28:43]

The CQ bit was checked by dougarnett@chromium.org

[commit-bot: I haz the power, 2016-05-26 14:28:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2015603002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2015603002/20001

[commit-bot: I haz the power, 2016-05-26 16:00:27]

Description was changed from

==========
PrerenderingLoader initial integration with PrerenderManager/PrerenderHandle and
make it unit-testable.

[Note: this CL landed and was reverted per test failure reported in issue
614699.]

It proved challenging to write unittests wrt mocking PrerenderManager and/or
PrerenderHandler and be able to create a stub PrerenderHandler without touching
the prerender stack code so this CL takes the approach of adding an adapter
between the Loader and prerender stack calls so that they can be intercepted for
testing.

BTW, PrerenderingLoader is actually the "BackgroundLoader" of
go/chrome-background-loading

TBR=fgorski@chromium.org,petewil@chromium.org,pasko@chromium.org,gabadie@chro...
BUG=601173,614699

Committed: https://crrev.com/8ed74fd7c401a1ff9a5a57c270409e0f66f6d3ce
Cr-Commit-Position: refs/heads/master@{#395485}

patch from issue 1968593002 at patchset 420001
(http://crrev.com/1968593002#ps420001)
==========

to

==========
PrerenderingLoader initial integration with PrerenderManager/PrerenderHandle and
make it unit-testable.

[Note: this CL landed and was reverted per test failure reported in issue
614699.]

It proved challenging to write unittests wrt mocking PrerenderManager and/or
PrerenderHandler and be able to create a stub PrerenderHandler without touching
the prerender stack code so this CL takes the approach of adding an adapter
between the Loader and prerender stack calls so that they can be intercepted for
testing.

BTW, PrerenderingLoader is actually the "BackgroundLoader" of
go/chrome-background-loading

TBR=fgorski@chromium.org,petewil@chromium.org,pasko@chromium.org,gabadie@chro...
BUG=601173,614699

Committed: https://crrev.com/8ed74fd7c401a1ff9a5a57c270409e0f66f6d3ce
Cr-Commit-Position: refs/heads/master@{#395485}

patch from issue 1968593002 at patchset 420001
(http://crrev.com/1968593002#ps420001)
==========

[commit-bot: I haz the power, 2016-05-26 16:00:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-26 16:02:14]

Description was changed from

==========
PrerenderingLoader initial integration with PrerenderManager/PrerenderHandle and
make it unit-testable.

[Note: this CL landed and was reverted per test failure reported in issue
614699.]

It proved challenging to write unittests wrt mocking PrerenderManager and/or
PrerenderHandler and be able to create a stub PrerenderHandler without touching
the prerender stack code so this CL takes the approach of adding an adapter
between the Loader and prerender stack calls so that they can be intercepted for
testing.

BTW, PrerenderingLoader is actually the "BackgroundLoader" of
go/chrome-background-loading

TBR=fgorski@chromium.org,petewil@chromium.org,pasko@chromium.org,gabadie@chro...
BUG=601173,614699

Committed: https://crrev.com/8ed74fd7c401a1ff9a5a57c270409e0f66f6d3ce
Cr-Commit-Position: refs/heads/master@{#395485}

patch from issue 1968593002 at patchset 420001
(http://crrev.com/1968593002#ps420001)
==========

to

==========
PrerenderingLoader initial integration with PrerenderManager/PrerenderHandle and
make it unit-testable.

[Note: this CL landed and was reverted per test failure reported in issue
614699.]

It proved challenging to write unittests wrt mocking PrerenderManager and/or
PrerenderHandler and be able to create a stub PrerenderHandler without touching
the prerender stack code so this CL takes the approach of adding an adapter
between the Loader and prerender stack calls so that they can be intercepted for
testing.

BTW, PrerenderingLoader is actually the "BackgroundLoader" of
go/chrome-background-loading

TBR=fgorski@chromium.org,petewil@chromium.org,pasko@chromium.org,gabadie@chro...
BUG=601173,614699

Committed: https://crrev.com/8ed74fd7c401a1ff9a5a57c270409e0f66f6d3ce
Cr-Commit-Position: refs/heads/master@{#395485}

patch from issue 1968593002 at patchset 420001
(http://crrev.com/1968593002#ps420001)

Committed: https://crrev.com/bd2f237c4acbdd9e0f6495b688f2c3da86127cac
Cr-Commit-Position: refs/heads/master@{#396191}
==========

[commit-bot: I haz the power, 2016-05-26 16:02:15]

Patchset 2 (id:??) landed as
https://crrev.com/bd2f237c4acbdd9e0f6495b688f2c3da86127cac
Cr-Commit-Position: refs/heads/master@{#396191}