Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

Issue 2015603002: PrerenderingLoader initial integration with PrerenderManager/PrerenderHandle and make it unit-testa… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adds mock adapter member initialization in constructor Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/prerendering_offliner.h" 5 #include "chrome/browser/android/offline_pages/prerendering_offliner.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "chrome/browser/android/offline_pages/prerendering_loader.h" 10 #include "chrome/browser/android/offline_pages/prerendering_loader.h"
11 #include "components/offline_pages/background/offliner.h" 11 #include "components/offline_pages/background/offliner.h"
12 #include "components/offline_pages/background/save_page_request.h" 12 #include "components/offline_pages/background/save_page_request.h"
13 #include "content/public/test/test_browser_thread_bundle.h"
13 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
14 15
15 namespace offline_pages { 16 namespace offline_pages {
16 17
17 namespace { 18 namespace {
18 const int64_t kRequestId = 7; 19 const int64_t kRequestId = 7;
19 const GURL kHttpUrl("http://tunafish.com"); 20 const GURL kHttpUrl("http://tunafish.com");
20 const GURL kFileUrl("file://sailfish.png"); 21 const GURL kFileUrl("file://sailfish.png");
21 const ClientId kClientId("AsyncLoading", "88"); 22 const ClientId kClientId("AsyncLoading", "88");
22 23
23 // Mock Loader for testing the Offliner calls. 24 // Mock Loader for testing the Offliner calls.
24 class MockPrerenderingLoader : public PrerenderingLoader { 25 class MockPrerenderingLoader : public PrerenderingLoader {
25 public: 26 public:
26 explicit MockPrerenderingLoader(content::BrowserContext* browser_context) 27 explicit MockPrerenderingLoader(content::BrowserContext* browser_context)
27 : PrerenderingLoader(browser_context), mock_loading_(false) {} 28 : PrerenderingLoader(browser_context),
29 mock_loading_(false),
30 mock_loaded_(false) {}
28 ~MockPrerenderingLoader() override {} 31 ~MockPrerenderingLoader() override {}
29 32
30 bool LoadPage(const GURL& url, const LoadPageCallback& callback) override { 33 bool LoadPage(const GURL& url, const LoadPageCallback& callback) override {
31 mock_loading_ = true; 34 mock_loading_ = true;
32 return mock_loading_; 35 return mock_loading_;
33 } 36 }
34 37
35 void StopLoading() override { mock_loading_ = false; } 38 void StopLoading() override {
39 mock_loading_ = false;
40 mock_loaded_ = false;
41 }
42 bool IsIdle() override { return !mock_loading_ && !mock_loaded_; }
43 bool IsLoaded() override { return mock_loaded_; }
36 44
37 bool mock_loading() const { return mock_loading_; } 45 bool mock_loading() const { return mock_loading_; }
38 46
39 private: 47 private:
40 bool mock_loading_; 48 bool mock_loading_;
49 bool mock_loaded_;
41 50
42 DISALLOW_COPY_AND_ASSIGN(MockPrerenderingLoader); 51 DISALLOW_COPY_AND_ASSIGN(MockPrerenderingLoader);
43 }; 52 };
44 53
45 } // namespace 54 } // namespace
46 55
47 class PrerenderingOfflinerTest : public testing::Test { 56 class PrerenderingOfflinerTest : public testing::Test {
48 public: 57 public:
49 PrerenderingOfflinerTest(); 58 PrerenderingOfflinerTest();
50 ~PrerenderingOfflinerTest() override; 59 ~PrerenderingOfflinerTest() override;
51 60
52 void SetUp() override; 61 void SetUp() override;
53 62
54 PrerenderingOffliner* offliner() const { return offliner_.get(); } 63 PrerenderingOffliner* offliner() const { return offliner_.get(); }
55 Offliner::CompletionCallback const callback() { 64 Offliner::CompletionCallback const callback() {
56 return base::Bind(&PrerenderingOfflinerTest::OnCompletion, 65 return base::Bind(&PrerenderingOfflinerTest::OnCompletion,
57 base::Unretained(this)); 66 base::Unretained(this));
58 } 67 }
59 68
60 bool loading() const { return loader_->mock_loading(); } 69 bool loading() const { return loader_->mock_loading(); }
61 Offliner::CompletionStatus completion_status() { 70 Offliner::RequestStatus completion_status() { return completion_status_; }
62 return completion_status_;
63 }
64 71
65 private: 72 private:
66 void OnCompletion(const SavePageRequest& request, 73 void OnCompletion(const SavePageRequest& request,
67 Offliner::CompletionStatus status); 74 Offliner::RequestStatus status);
68 75
76 content::TestBrowserThreadBundle thread_bundle_;
69 std::unique_ptr<PrerenderingOffliner> offliner_; 77 std::unique_ptr<PrerenderingOffliner> offliner_;
70 // Not owned. 78 // Not owned.
71 MockPrerenderingLoader* loader_; 79 MockPrerenderingLoader* loader_;
72 Offliner::CompletionStatus completion_status_; 80 Offliner::RequestStatus completion_status_;
73 81
74 DISALLOW_COPY_AND_ASSIGN(PrerenderingOfflinerTest); 82 DISALLOW_COPY_AND_ASSIGN(PrerenderingOfflinerTest);
75 }; 83 };
76 84
77 PrerenderingOfflinerTest::PrerenderingOfflinerTest() {} 85 PrerenderingOfflinerTest::PrerenderingOfflinerTest()
86 : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP) {}
78 87
79 PrerenderingOfflinerTest::~PrerenderingOfflinerTest() {} 88 PrerenderingOfflinerTest::~PrerenderingOfflinerTest() {}
80 89
81 void PrerenderingOfflinerTest::SetUp() { 90 void PrerenderingOfflinerTest::SetUp() {
82 offliner_.reset(new PrerenderingOffliner(nullptr, nullptr, nullptr)); 91 offliner_.reset(new PrerenderingOffliner(nullptr, nullptr, nullptr));
83 std::unique_ptr<MockPrerenderingLoader> mock_loader( 92 std::unique_ptr<MockPrerenderingLoader> mock_loader(
84 new MockPrerenderingLoader(nullptr)); 93 new MockPrerenderingLoader(nullptr));
85 loader_ = mock_loader.get(); 94 loader_ = mock_loader.get();
86 offliner_->SetLoaderForTesting(std::move(mock_loader)); 95 offliner_->SetLoaderForTesting(std::move(mock_loader));
87 } 96 }
88 97
89 void PrerenderingOfflinerTest::OnCompletion(const SavePageRequest& request, 98 void PrerenderingOfflinerTest::OnCompletion(const SavePageRequest& request,
90 Offliner::CompletionStatus status) { 99 Offliner::RequestStatus status) {
91 completion_status_ = status; 100 completion_status_ = status;
92 } 101 }
93 102
94 // Tests initiate loading. 103 // Tests initiate loading.
95 TEST_F(PrerenderingOfflinerTest, LoadAndSaveBadUrl) { 104 TEST_F(PrerenderingOfflinerTest, LoadAndSaveBadUrl) {
96 base::Time creation_time = base::Time::Now(); 105 base::Time creation_time = base::Time::Now();
97 SavePageRequest request(kRequestId, kFileUrl, kClientId, creation_time); 106 SavePageRequest request(kRequestId, kFileUrl, kClientId, creation_time);
98 EXPECT_FALSE(offliner()->LoadAndSave(request, callback())); 107 EXPECT_FALSE(offliner()->LoadAndSave(request, callback()));
99 EXPECT_FALSE(loading()); 108 EXPECT_FALSE(loading());
100 } 109 }
(...skipping 11 matching lines...) Expand all
112 base::Time creation_time = base::Time::Now(); 121 base::Time creation_time = base::Time::Now();
113 SavePageRequest request(kRequestId, kHttpUrl, kClientId, creation_time); 122 SavePageRequest request(kRequestId, kHttpUrl, kClientId, creation_time);
114 EXPECT_TRUE(offliner()->LoadAndSave(request, callback())); 123 EXPECT_TRUE(offliner()->LoadAndSave(request, callback()));
115 EXPECT_TRUE(loading()); 124 EXPECT_TRUE(loading());
116 125
117 offliner()->Cancel(); 126 offliner()->Cancel();
118 EXPECT_FALSE(loading()); 127 EXPECT_FALSE(loading());
119 } 128 }
120 129
121 } // namespace offline_pages 130 } // namespace offline_pages
OLDNEW
« no previous file with comments | « chrome/browser/android/offline_pages/prerendering_offliner.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698