Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2970)

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner.cc

Issue 2015603002: PrerenderingLoader initial integration with PrerenderManager/PrerenderHandle and make it unit-testa… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adds mock adapter member initialization in constructor Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_offliner.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_offliner.cc b/chrome/browser/android/offline_pages/prerendering_offliner.cc
index c38afcb7ab8f248ff3751aa2ecabf301cdf3c91c..b654c75a6b5620ebe6bf03e7d525daa88a111cb0 100644
--- a/chrome/browser/android/offline_pages/prerendering_offliner.cc
+++ b/chrome/browser/android/offline_pages/prerendering_offliner.cc
@@ -20,9 +20,8 @@ PrerenderingOffliner::PrerenderingOffliner(
PrerenderingOffliner::~PrerenderingOffliner() {}
-void PrerenderingOffliner::OnLoadPageDone(
- const Offliner::CompletionStatus load_status,
- content::WebContents* contents) {
+void PrerenderingOffliner::OnLoadPageDone(Offliner::RequestStatus load_status,
+ content::WebContents* contents) {
// TODO(dougarnett): Implement save attempt and running CompletionCallback.
}
@@ -41,6 +40,12 @@ void PrerenderingOffliner::Cancel() {
GetOrCreateLoader()->StopLoading();
}
+void PrerenderingOffliner::SetLoaderForTesting(
+ std::unique_ptr<PrerenderingLoader> loader) {
+ DCHECK(!loader_);
+ loader_ = std::move(loader);
+}
+
PrerenderingLoader* PrerenderingOffliner::GetOrCreateLoader() {
if (!loader_) {
loader_.reset(new PrerenderingLoader(browser_context_));
@@ -48,10 +53,4 @@ PrerenderingLoader* PrerenderingOffliner::GetOrCreateLoader() {
return loader_.get();
}
-void PrerenderingOffliner::SetLoaderForTesting(
- std::unique_ptr<PrerenderingLoader> loader) {
- DCHECK(!loader_);
- loader_ = std::move(loader);
-}
-
} // namespace offline_pages

Powered by Google App Engine
This is Rietveld 408576698