Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Unified Diff: components/offline_pages/background/offliner.h

Issue 2015603002: PrerenderingLoader initial integration with PrerenderManager/PrerenderHandle and make it unit-testa… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adds mock adapter member initialization in constructor Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | components/offline_pages/background/request_coordinator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/background/offliner.h
diff --git a/components/offline_pages/background/offliner.h b/components/offline_pages/background/offliner.h
index e24506075929e32a397a30ef24ecc81c1450f289..ead1adfa503113459cc5ff016081727ce98f6376 100644
--- a/components/offline_pages/background/offliner.h
+++ b/components/offline_pages/background/offliner.h
@@ -15,18 +15,19 @@ class SavePageRequest;
// a request with a URL.
class Offliner {
public:
- // Completion status of processing an offline page request.
- enum CompletionStatus {
- SAVED = 0,
- CANCELED = 1,
- FAILED_CONSIDER_RETRY = 2,
- FAILED_DO_NOT_RETRY = 3,
- UNKNOWN = 4,
+ // Status of processing an offline page request.
+ enum class RequestStatus {
+ UNKNOWN, // No status determined/reported yet.
+ LOADED, // Page loaded but not (yet) saved.
+ SAVED, // Offline page snapshot saved.
+ CANCELED, // Request was canceled.
+ FAILED, // Request failed.
+ // TODO(dougarnett): Define a retry-able failure status.
};
// Reports the completion status of a request.
// TODO(dougarnett): consider passing back a request id instead of request.
- typedef base::Callback<void(const SavePageRequest&, CompletionStatus)>
+ typedef base::Callback<void(const SavePageRequest&, RequestStatus)>
CompletionCallback;
Offliner() {}
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | components/offline_pages/background/request_coordinator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698