Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2014903002: [Media Router] Consistently refer to issue's learn more help page by ID. (Closed)

Created:
4 years, 7 months ago by apacible
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Media Router] Consistently refer to issue's learn more help page by ID. When users click on "learn more" on an issue, there should be a new tab opened to the "learn more" link. Currently, some parts of Media Router assume that an Issue keeps track of a URL, whereas other places assume that it keeps track of the help page ID, which would later be concat'd to a help center URL prefix. This mismatch breaks the "learn more" link for any issues created in the extension. This change makes Issues consistently refer to the help page ID. Also fix presubmit warnings. BUG=613242 Review-Url: https://codereview.chromium.org/1993373002 Cr-Commit-Position: refs/heads/master@{#395615} (cherry picked from commit e68cd12ddd2fcc30c317c5725a5349ba0524be34) Committed: https://chromium.googlesource.com/chromium/src/+/5b04f2be4168d4fece67a79a212e5b522a98ca0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -38 lines) Patch
M chrome/browser/media/router/issue.h View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/media/router/issue.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media/router/issue_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/router/issue_unittest.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/router/mojo/media_router_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/media/router/test_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/media_router_action_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/renderer/resources/media_router_bindings.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
apacible
4 years, 7 months ago (2016-05-26 17:47:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5b04f2be4168d4fece67a79a212e5b522a98ca0a.

Powered by Google App Engine
This is Rietveld 408576698