Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1458)

Unified Diff: chrome/browser/media/router/issue.cc

Issue 2014903002: [Media Router] Consistently refer to issue's learn more help page by ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/router/issue.h ('k') | chrome/browser/media/router/issue_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/router/issue.cc
diff --git a/chrome/browser/media/router/issue.cc b/chrome/browser/media/router/issue.cc
index 6afa57e4c01cf2fe9bf2e6bb7be42b8709f6217d..0dd3488c63b7b60a9904e79744228d9aa5731bb2 100644
--- a/chrome/browser/media/router/issue.cc
+++ b/chrome/browser/media/router/issue.cc
@@ -20,7 +20,7 @@ Issue::Issue(const std::string& title,
const MediaRoute::Id& route_id,
const Issue::Severity severity,
bool is_blocking,
- const std::string& help_url)
+ int help_page_id)
: title_(title),
message_(message),
default_action_(default_action),
@@ -29,7 +29,7 @@ Issue::Issue(const std::string& title,
severity_(severity),
id_(base::GenerateGUID()),
is_blocking_(is_blocking),
- help_url_(GURL(help_url)) {
+ help_page_id_(help_page_id) {
DCHECK(!title_.empty());
DCHECK(severity_ != FATAL || is_blocking_) << "Severity is " << severity_;
« no previous file with comments | « chrome/browser/media/router/issue.h ('k') | chrome/browser/media/router/issue_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698