[Media Router] Consistently refer to issue's learn more help page by ID.

[Media Router] Consistently refer to issue's learn more help page by ID.

When users click on "learn more" on an issue, there should be a new tab opened to the "learn more" link. Currently, some parts of Media Router assume that an Issue keeps track of a URL, whereas other places assume that it keeps track of the help page ID, which would later be concat'd to a help center URL prefix. This mismatch breaks the "learn more" link for any issues created in the extension.

This change makes Issues consistently refer to the help page ID.

Also fix presubmit warnings.

BUG=613242
Committed: https://crrev.com/e68cd12ddd2fcc30c317c5725a5349ba0524be34
Cr-Commit-Position: refs/heads/master@{#395615}

[apacible, 2016-05-19 21:10:35]

Description was changed from

==========
adf

BUG=
==========

to

==========
[Media Router] Consistently refer to issue's learn more help page by ID.

Currently, some parts of Media Router assume that an Issue keeps track of a URL,
whereas other places assume that it keeps track of the help page ID, which would
later be concat'd to a help center URL prefix.

This change makes Issues consistently refer to the help page ID.

BUG=613242
==========

[apacible, 2016-05-19 21:13:07]

Patchset #1 (id:1) has been deleted

[apacible, 2016-05-19 21:14:11]

Description was changed from

==========
[Media Router] Consistently refer to issue's learn more help page by ID.

Currently, some parts of Media Router assume that an Issue keeps track of a URL,
whereas other places assume that it keeps track of the help page ID, which would
later be concat'd to a help center URL prefix.

This change makes Issues consistently refer to the help page ID.

BUG=613242
==========

to

==========
[Media Router] Consistently refer to issue's learn more help page by ID.

Currently, some parts of Media Router assume that an Issue keeps track of a URL,
whereas other places assume that it keeps track of the help page ID, which would
later be concat'd to a help center URL prefix.

This change makes Issues consistently refer to the help page ID.

Also fix presubmit warnings.

BUG=613242
==========

[apacible, 2016-05-19 21:15:19]

Description was changed from

==========
[Media Router] Consistently refer to issue's learn more help page by ID.

Currently, some parts of Media Router assume that an Issue keeps track of a URL,
whereas other places assume that it keeps track of the help page ID, which would
later be concat'd to a help center URL prefix.

This change makes Issues consistently refer to the help page ID.

Also fix presubmit warnings.

BUG=613242
==========

to

==========
[Media Router] Consistently refer to issue's learn more help page by ID.

When users click on "learn more" on an issue, there should be a new tab opened
to the "learn more" link. Currently, some parts of Media Router assume that an
Issue keeps track of a URL, whereas other places assume that it keeps track of
the help page ID, which would later be concat'd to a help center URL prefix.
This mismatch breaks the "learn more" link for any issues created in the
extension.

This change makes Issues consistently refer to the help page ID.

Also fix presubmit warnings.

BUG=613242
==========

[apacible, 2016-05-19 21:15:37]

apacible@chromium.org changed reviewers:
+ imcheng@chromium.org

[apacible, 2016-05-19 21:16:48]

apacible@chromium.org changed reviewers:
+ msw@chromium.org

[apacible, 2016-05-19 21:16:49]

PTAL, thanks!

OWNERS:
+ imcheng for everything
+ msw for c/b/ui/toolbar

[imcheng, 2016-05-23 20:02:42]

lgtm % comments

https://codereview.chromium.org/1993373002/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/issue.h (right):

https://codereview.chromium.org/1993373002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/issue.h:53: // |help_page_id|: Required if one of
the actions is learn-more.
I would add something like: Pass in -1 if the issue is not associated with a
help page.

https://codereview.chromium.org/1993373002/diff/20001/extensions/renderer/res...
File extensions/renderer/resources/media_router_bindings.js (right):

https://codereview.chromium.org/1993373002/diff/20001/extensions/renderer/res...
extensions/renderer/resources/media_router_bindings.js:356: 'help_page_id':
issue.help_page_id,
nit: issue.helpPageId.

[apacible, 2016-05-23 20:21:19]

Patchset #2 (id:40001) has been deleted

[apacible, 2016-05-23 20:22:52]

https://codereview.chromium.org/1993373002/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/issue.h (right):

https://codereview.chromium.org/1993373002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/issue.h:53: // |help_page_id|: Required if one of
the actions is learn-more.
On 2016/05/23 20:02:42, imcheng wrote:
> I would add something like: Pass in -1 if the issue is not associated with a
> help page.

Done.

https://codereview.chromium.org/1993373002/diff/20001/extensions/renderer/res...
File extensions/renderer/resources/media_router_bindings.js (right):

https://codereview.chromium.org/1993373002/diff/20001/extensions/renderer/res...
extensions/renderer/resources/media_router_bindings.js:356: 'help_page_id':
issue.help_page_id,
On 2016/05/23 20:02:42, imcheng wrote:
> nit: issue.helpPageId.

Done.

[apacible, 2016-05-23 20:22:56]

The CQ bit was checked by apacible@chromium.org

[apacible, 2016-05-23 20:22:56]

The patchset sent to the CQ was uploaded after l-g-t-m from imcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1993373002/#ps60001
(title: "Changes per imcheng@'s comments.")

[commit-bot: I haz the power, 2016-05-23 20:23:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1993373002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1993373002/60001

[commit-bot: I haz the power, 2016-05-23 20:31:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-23 20:31:59]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[apacible, 2016-05-23 20:34:11]

Oops. msw - PTAL, thanks! :)

[msw, 2016-05-24 16:44:55]

lgtm

[apacible, 2016-05-24 16:50:19]

The CQ bit was checked by apacible@chromium.org

[commit-bot: I haz the power, 2016-05-24 16:50:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1993373002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1993373002/60001

[commit-bot: I haz the power, 2016-05-24 16:55:32]

Description was changed from

==========
[Media Router] Consistently refer to issue's learn more help page by ID.

When users click on "learn more" on an issue, there should be a new tab opened
to the "learn more" link. Currently, some parts of Media Router assume that an
Issue keeps track of a URL, whereas other places assume that it keeps track of
the help page ID, which would later be concat'd to a help center URL prefix.
This mismatch breaks the "learn more" link for any issues created in the
extension.

This change makes Issues consistently refer to the help page ID.

Also fix presubmit warnings.

BUG=613242
==========

to

==========
[Media Router] Consistently refer to issue's learn more help page by ID.

When users click on "learn more" on an issue, there should be a new tab opened
to the "learn more" link. Currently, some parts of Media Router assume that an
Issue keeps track of a URL, whereas other places assume that it keeps track of
the help page ID, which would later be concat'd to a help center URL prefix.
This mismatch breaks the "learn more" link for any issues created in the
extension.

This change makes Issues consistently refer to the help page ID.

Also fix presubmit warnings.

BUG=613242
==========

[commit-bot: I haz the power, 2016-05-24 16:55:33]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-05-24 16:56:49]

Description was changed from

==========
[Media Router] Consistently refer to issue's learn more help page by ID.

When users click on "learn more" on an issue, there should be a new tab opened
to the "learn more" link. Currently, some parts of Media Router assume that an
Issue keeps track of a URL, whereas other places assume that it keeps track of
the help page ID, which would later be concat'd to a help center URL prefix.
This mismatch breaks the "learn more" link for any issues created in the
extension.

This change makes Issues consistently refer to the help page ID.

Also fix presubmit warnings.

BUG=613242
==========

to

==========
[Media Router] Consistently refer to issue's learn more help page by ID.

When users click on "learn more" on an issue, there should be a new tab opened
to the "learn more" link. Currently, some parts of Media Router assume that an
Issue keeps track of a URL, whereas other places assume that it keeps track of
the help page ID, which would later be concat'd to a help center URL prefix.
This mismatch breaks the "learn more" link for any issues created in the
extension.

This change makes Issues consistently refer to the help page ID.

Also fix presubmit warnings.

BUG=613242

Committed: https://crrev.com/e68cd12ddd2fcc30c317c5725a5349ba0524be34
Cr-Commit-Position: refs/heads/master@{#395615}
==========

[commit-bot: I haz the power, 2016-05-24 16:56:51]

Patchset 2 (id:??) landed as
https://crrev.com/e68cd12ddd2fcc30c317c5725a5349ba0524be34
Cr-Commit-Position: refs/heads/master@{#395615}