chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc - Issue 2014903002: [Media Router] Consistently refer to issue's learn more help page by ID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc

Issue 2014903002: [Media Router] Consistently refer to issue's learn more help page by ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc ('k') | extensions/renderer/resources/media_router_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc

diff --git a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc

index 725beb2aa258ee4c045f2faa1f93c25ac2b146ad..c60d8e1f0e0f5151ece4ad2ae388724eed43b645 100644

--- a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc

+++ b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc

@@ -21,8 +21,8 @@ namespace media_router {

const char kProviderExtensionIdForTesting[] = "test_id";

const char kControllerPathForTesting[] = "test_path";

-const std::string kUserEmailForTesting = "nobody@example.com";

-const std::string kUserDomainForTesting = "example.com";

+const char kUserEmailForTesting[] = "nobody@example.com";

+const char kUserDomainForTesting[] = "example.com";

class MockMediaRouterUI : public MediaRouterUI {

public:

@@ -438,7 +438,7 @@ TEST_F(MediaRouterWebUIMessageHandlerTest, UpdateIssue) {

MediaRoute::Id route_id("routeId123");

bool is_blocking = true;

Issue issue(issue_title, issue_message, default_action, secondary_actions,

- route_id, Issue::FATAL, is_blocking, "helpUrl");

+ route_id, Issue::FATAL, is_blocking, -1);

const Issue::Id& issue_id = issue.id();

handler_->UpdateIssue(&issue);